{{ message }}
ci: wait for VALIDATED instead of PUBLISHED on Maven Central release#354
Merged
Conversation
The release workflow set mavenCentralDeploymentValidation to PUBLISHED, so the vanniktech plugin polled until the deployment reached the final PUBLISHED state. Central's publish-to-repo1 propagation can take well over an hour, exceeding the plugin's 900s SONATYPE_CLOSE_TIMEOUT_SECONDS default, which failed the v0.9.0 release job even though the artifacts published successfully. Wait for VALIDATED instead: the job blocks until Central accepts the uploaded bundle (a minute or two) and then publishes asynchronously. This still guards against the failure mode that motivated PUBLISHED in the first place (a bundle that never reaches Central), since a VALIDATED deployment with automatic publishing is guaranteed to publish. Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.9.0 release job failed even though all artifacts published successfully to Maven Central.
The workflow set
mavenCentralDeploymentValidation: PUBLISHED, so the vanniktech plugin polled until the deployment reached the finalPUBLISHEDstate. Central's propagation to repo1 took over an hour that day, exceeding the plugin's defaultSONATYPE_CLOSE_TIMEOUT_SECONDSof 900s:The deployment had already passed validation and was in
PUBLISHING— the publish was fine; only the workflow's wait timed out.Fix
Wait for
VALIDATEDinstead ofPUBLISHED. The job blocks until Central accepts the uploaded bundle (a minute or two), then Central publishes asynchronously.This still guards against the failure mode that originally motivated
PUBLISHED(the v0.7.5 incident, where a bundle never reached Central): aVALIDATEDdeployment with automatic publishing is guaranteed to publish. The only thing we give up is the workflow confirming repo1 propagation before going green — which is outside our control and not worth tying up a CI runner for an hour (or flaking when it exceeds even a raised timeout).