Fix template usage by timkelty · Pull Request #41 · ostark/upper · GitHub
Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

Fix template usage - #41

Merged
timkelty merged 7 commits into
ostark:masterfrom
timkelty:fix-template-usage
Oct 15, 2021
Merged

Fix template usage#41
timkelty merged 7 commits into
ostark:masterfrom
timkelty:fix-template-usage

Conversation

@timkelty

Copy link
Copy Markdown
Collaborator

Looks like this feature came in a little half-baked…

The TwigExtension was there but never registered.
Also, type checking on the constructor would fail on console requests.

@timkelty

timkelty commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator Author

Comment thread src/CacheResponse.php Outdated
Comment thread src/TwigExtension.php
@timkelty
timkelty merged commit 95b7ec4 into ostark:master Oct 15, 2021
@timkelty
timkelty deleted the fix-template-usage branch October 15, 2021 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants