{{ message }}
Update GitHub Actions caching strategy#8866
Open
zwass wants to merge 7 commits into
Open
Conversation
Caches need only be different for each platform, not for each OS version and architecture (since they should be source-only).
zwass
added
CI/CD
zwass
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions caching strategy in hosted_runners.yml to reduce cache fragmentation by keying git submodule caches by platform + submodule state (hash) and keying downloads caches by platform, while restricting cache writes to the default branch.
Changes:
- Removed the
SUBMODULE_CACHE_VERSIONenv and replaced submodule cache keys withrunner.os+ a computed SHA-256 hash ofgit submodule status --recursive. - Split cache usage into explicit restore vs. save steps, and gated cache saves to the repository default branch.
- Simplified downloads cache keys/restore keys to be platform-scoped (via
runner.os).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
687
to
689
|
|
||
| - name: Save cache (git submodules) | ||
| if: github.ref_name == github.event.repository.default_branch | ||
| uses: actions/cache@v4 |
|
|
||
| - name: Save cache (git submodules) | ||
| if: github.ref_name == github.event.repository.default_branch | ||
| uses: actions/cache@v4 |
|
|
||
| - name: Save cache (git submodules) | ||
| if: github.ref_name == github.event.repository.default_branch | ||
| uses: actions/cache@v4 |
|
|
||
| - name: Save cache (downloads) | ||
| if: github.ref_name == github.event.repository.default_branch | ||
| uses: actions/cache@v4 |
|
|
||
| - name: Save cache (git submodules) | ||
| if: github.ref_name == github.event.repository.default_branch | ||
| uses: actions/cache@v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.