chore: bump minimum Go version to 1.26 by Ricky-7-Yan · Pull Request #1417 · oras-project/oras-go · GitHub
Skip to content

chore: bump minimum Go version to 1.26 - #1417

Merged
TerryHowe merged 4 commits into
oras-project:mainfrom
Ricky-7-Yan:chore/go-1.26-minimum
Sep 10, 2026
Merged

TerryHowe merged 4 commits into
oras-project:mainfrom
Ricky-7-Yan:chore/go-1.26-minimum

Conversation

@Ricky-7-Yan

Copy link
Copy Markdown
Contributor

Closes #1416.

Summary

  • bump the module and golangci target from Go 1.25 to Go 1.26
  • move the build and CodeQL matrices to the supported Go 1.26/1.27 window, and run lint on Go 1.26
  • refresh the README support-window note

Validation

  • go mod tidy with Go 1.26.0 (no go.sum changes)
  • go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.13.2 run (0 issues)
  • CGO_ENABLED=0 go test -coverprofile=coverage.txt -covermode=atomic ./... on Linux/amd64 as a non-root user (all packages passed)
  • git diff --check

Signed-off-by: Ricky-7-Yan <2314530442@qq.com>
@github-advanced-security

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.85%. Comparing base (096a68d) to head (fe30450).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
+ Coverage   85.14%   90.85%   +5.71%     
==========================================
  Files          95       95              
  Lines        7283     7283              
==========================================
+ Hits         6201     6617     +416     
+ Misses        657      654       -3     
+ Partials      425       12     -413     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TerryHowe and others added 3 commits September 9, 2026 13:38
The dependency license check runs via apache/skywalking-eyes, whose
composite action pins its own Go 1.25 toolchain and exports
GOTOOLCHAIN=local. With go.mod now requiring go >= 1.26.0, license-eye
fails to resolve the module graph:

  go: go.mod requires go >= 1.26.0 (running go 1.25.14; GOTOOLCHAIN=local)

Set GOTOOLCHAIN=auto on the job so the required toolchain can be
fetched. Upstream has no release that pins a newer Go: v0.9.0 is the
latest and main still hardcodes go-version: 1.25.

Signed-off-by: Terry Howe <thowe@nvidia.com>
Signed-off-by: Ricky-7-Yan <2314530442@qq.com>
@Ricky-7-Yan

Copy link
Copy Markdown
Contributor Author

Thanks @TerryHowe — your diagnosis was right. The remaining failure came from the dependency composite action exporting GOTOOLCHAIN=local after the job-level setting, as confirmed by the failed log. I pushed fe30450: the header action still installs and runs the same license-eye binary, while the dependency check now invokes that binary directly with a step-level GOTOOLCHAIN=auto. This keeps the scanner/config unchanged and avoids the composite action's internal Go 1.25 reset. actionlint v1.7.12 and git diff --check pass locally; CI is rerunning.

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe
TerryHowe merged commit 624bbb8 into oras-project:main Sep 10, 2026
10 checks passed
@TerryHowe

Copy link
Copy Markdown
Member

@TerryHowe TerryHowe mentioned this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump minimum Go version to 1.26

3 participants