{{ message }}
chore: Preparing for release#229
Merged
Merged
Conversation
…es. (#227) * refactor batch_event_processor to reset deadline after it passes. Also, hang on queue with timeout at flush interval * fix lint error * lint * fix lint error * finally got to debug replacing the mock logger * update to take time in float * add unit tests for float flush deadline and flush interval * fix broken test * update method description * added a unit test to make sure processor is called once during flush interval * lint error
* add more debug logging * take out in seconds. already in seconds * Revert "take out in seconds. already in seconds" This reverts commit 9c0cca8. * update logging to log when batch is empty on flush or flush of batch size * use mock logger * rename flush_queue to flush_batch and update debug messages. fix one bug where current_batch was being reset without a lock. * cleanup incorrect comments
* Bumping version for release * Updating CHANGELOG * add debug pr to list for change log
3 similar comments
Contributor
mikeproeng37
approved these changes
Dec 17, 2019
mikeproeng37
left a comment
mikeproeng37
left a comment
Contributor
There was a problem hiding this comment.
Releasing here should be fine. But we should standardize in releasing from master in the near future for releases that are current with master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.