{{ message }}
Repository navigation
commands,pkg/scaffold,hack,pkg/helm: run and migrate command support for helm - #897
Merged
joelanford merged 7 commits intoJan 15, 2019
Merged
Conversation
…command support for helm
joelanford
requested review from
AlexNPavel,
estroz,
hasbro17,
lilic,
mhrivnak and
shawn-hurley
January 10, 2019 17:35
openshift-ci-robot
added
the
size/XL
mhrivnak
approved these changes
Jan 10, 2019
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
hasbro17
reviewed
Jan 14, 2019
hasbro17
reviewed
Jan 14, 2019
Contributor
There was a problem hiding this comment.
I just remembered that we need to update this scaffold for each release as well now.
@joelanford Can you please update the release guide section for the version update as well.
We need to bump both pkg/scaffold/ansible/gopkgtoml.go and this file pkg/scaffold/helm/gopkgtoml.go
@estroz We just need to add checks for these two files in the release.sh script to ensure the versions are set correctly at release time as well right? Similar to the existing checks:
https://github.com/operator-framework/operator-sdk/blob/master/release.sh#L38-L41
Contributor
There was a problem hiding this comment.
@estroz scratch that. I just saw @joelanford already added the check for this file down in release.sh.
This was referenced Jan 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding support for the
operator-sdk run helmcommand andoperator-sdk migratecommand in the context of an existing helm operator (see #887 for similar work done for ansible)Motivation for the change:
See #860