{{ message }}
Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues, with existing retry behavior preserved and focused builder coverage added; tests were not executed.
0 open findings
What changed in this PR
Refactors GenericRetry toward builder-based configuration while preserving existing retry behavior and annotation support.
Changes:
- Adds a builder,
toBuilder(), and diagnostictoString(); deprecates mutable configuration methods. - Migrates configuration loading, tests, and documentation to the builder API.
- Adds tests for builder defaults, configuration copying, and independent instances.
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TQJADE
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a builder for
GenericRetryas a non-breaking first step towardsmaking it immutable in v6. The mutating methods are deprecated for
removal, so users can migrate now and the setters can be dropped in the
next major version. More: #2935
Summary by CodeRabbit
New Features
Documentation