{{ message }}
Repository navigation
fix: rename version.properties to a unique name to avoid resource collisions - #3628
Merged
csviri merged 1 commit intoSep 18, 2026
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The public overload removal is breaking, and the resource rename needs migration documentation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Renames the SDK version metadata resource to prevent collisions in shaded JARs.
Changes:
- Generates and loads
operator-sdk-version.properties. - Exposes the resource name and adds regression coverage.
- Removes the three-argument
ensureValidoverload.
File summaries
| File | Description |
|---|---|
operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/VersionTest.java |
Verifies resource discovery and commit metadata. |
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Utils.java |
Uses the new resource name and removes the overload. |
operator-framework-core/pom.xml |
Updates the generated properties filename. |
Review details
Suppressed comments (1)
operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Utils.java:45
- This changes a publicly observable resource path, and the PR description explicitly calls out consumers that read or register the file directly. Please add the old-to-new resource-name migration note to the shipped release/migration documentation, including
Utils.VERSION_PROPERTIES_FILE_NAME; otherwise shaded or native-image integrations can silently break on upgrade.
public static final String VERSION_PROPERTIES_FILE_NAME = "operator-sdk-version.properties";
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
afalhambra-hivemq
force-pushed
the
fix/unique-version-properties-resource
branch
from
September 18, 2026 09:06
2dcef69 to
d1b28b4
Compare
…lisions Signed-off-by: Antonio Fernandez Alhambra <antonio.alhambra@hivemq.com>
afalhambra-hivemq
force-pushed
the
fix/unique-version-properties-resource
branch
from
September 18, 2026 09:08
d1b28b4 to
c78427d
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3627.
Note (for the release notes?): in case of anyone reading
version.propertiesdirectly from the operator-framework-core jar needs to switch to the new file name.PR for the JOSDK webhook repo: operator-framework/josdk-webhooks#415