{{ message }}
OCPBUGS-3469: Multi-arch support#114
Merged
Merged
Conversation
everettraven
requested changes
Mar 6, 2023
everettraven
left a comment
everettraven
left a comment
Collaborator
There was a problem hiding this comment.
These changes currently don't work when attempting to initialize a project using operator-sdk init .... I left a comment showing the error I received and what I think the solution is.
Another thing I noticed is there is a few commits with multiple contributors and looks like it would re-commit a few already merged commits. I think a git rebase (or similar operation) may have gone a bit off the rails as I would have only expected the Makefile template and the testdata to be updated by this PR.
oceanc80
force-pushed
the
multi-arch
branch
2 times, most recently
from
86f6323 to
8816187
Compare
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
laxmikantbpandhare
approved these changes
Mar 9, 2023
laxmikantbpandhare
left a comment
laxmikantbpandhare
left a comment
Member
There was a problem hiding this comment.
/lgtm
I will try updated tutorial steps on the weekend.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable multi-arch build support