{{ message }}
Adapt the unit test action to not use a docker image.#117
Open
drgrice1 wants to merge 1 commit into
Open
Conversation
Member
Author
drgrice1
force-pushed
the
no-docker-unit-tests
branch
9 times, most recently
from
3526107 to
ed65ddf
Compare
Member
Author
|
The docker image built with the It would be nice to force the tests to use a specific JSON backend module, regardless of what is installed on the system. The environment variables PERL_JSON_BACKEND and MOJO_NO_JSON_XS should work for this, but they don't for some reason. |
drgrice1
force-pushed
the
no-docker-unit-tests
branch
3 times, most recently
from
e4a9e7f to
9ac35f1
Compare
Member
Author
drgrice1
force-pushed
the
no-docker-unit-tests
branch
2 times, most recently
from
097d230 to
587dd60
Compare
drgrice1
force-pushed
the
no-docker-unit-tests
branch
6 times, most recently
from
b8bcaa6 to
23e8c3a
Compare
This uses Ubuntu 22.04 for the runner and docker image.
drgrice1
force-pushed
the
no-docker-unit-tests
branch
from
23e8c3a to
84a22e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just uses the ubuntu 22.04 runner, and installs the webwork3 dependencies directly, and then runs the unit tests. It actually doesn't take much longer to do this than to use the prebuilt docker image.
This is one way to solve the issue of the dependence on a docker image that does not belong to the openwebwork project.
There is one issue though. Several of the tests were failing with this new approach. Looking closely at the tests that were failing, I realized that those tests should be failing. All of the tests that were failing were boolean values compared to numerical values. Those tests have been fixed in this pull request. However, the issue is that for some reason the fixed tests were passing for us when we run the tests on our local machines and they were passing in the previous docker image approach. We need to figure this out, so that we don't need to wait until the workflow has run to see what needs to be fixed.
The dockerfile used for the previous workflow image has also been updated for new Ubuntu package versions. Also the dependencies of Devel::Cover::Report::Codecove that are available in the Ubuntu repositories are installed via those packages. This speeds up the build some. Ubuntu packages install faster than building from cpan source via cpanm.
Note there was an instance in lib/DB/Schema/Result/ProblemSet.pm of a boolean column, and so that package should load the InflateColumn::Boolean class. Also, all of the
__PACKAGE__->load_componentscalls were made uniform.