Repository navigation
tests/e2e: increase three-BSLs default BSL availability timeout from 180s to 300s - #2485
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit faddcc8 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## oadp-1.4 #2485 +/- ##
=========================================
Coverage 40.03% 40.03%
=========================================
Files 30 30
Lines 5378 5378
=========================================
Hits 2153 2153
Misses 3014 3014
Partials 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
openshift-ci
Bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/lgtm |
|
/retest-required |
The BSL controller uses a single worker, so when it picks up a non-default BSL with a dummy CA certificate first, it blocks on TLS retry before reconciling the default BSL. With 2-of-3 BSLs carrying dummy certs, there is a ~67% probability the worker grabs a bad one first, causing the default BSL to miss the original 180s (3 min) timeout. Increase the timeout from 3 minutes to 5 minutes (300s) to give the controller enough headroom to work through the TLS-retrying BSLs before reaching the default one. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
379bb1e to
faddcc8
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Increase the default BSL availability timeout from 180s to 300s in the three-BSLs test to accommodate BSL controller head-of-line blocking.
Problem
The "three BSLs with backupImages=false" test (introduced by PR #2466, cherry-pick of #1969) creates three BackupStorageLocations, two of which have dummy CA certificates. The BSL controller has a single worker that processes BSLs sequentially. When the worker picks up a BSL with a dummy cert first, it blocks on TLS handshake retries, delaying reconciliation of the default (valid) BSL beyond the 180s timeout. With 2-of-3 BSLs having dummy certs, there is approximately a 67% probability of hitting this on any given run.
Changes
time.Minute*3(180s) totime.Minute*5(300s) for the default BSL availability checkBackport targets: oadp-dev, oadp-1.6, oadp-1.5
AI-generated. Review for accuracy.
@kaovilai requested from Slack