{{ message }}
fix: Add missing config set jira-email#962
Open
Tof1973 wants to merge 2 commits into
Open
Conversation
openshift-ci
Bot
added
the
tide/merge-method-squash
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tof1973 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/ocm-backplane/config/set.go`:
- Line 120: The setConfig flow is overwriting the saved Jira email even when
updating unrelated settings because bpConfig.JiraEmail is never hydrated from
viper before viper.Set is called. In setConfig, either load the existing Jira
email from viper alongside JiraToken before writing, or guard the
viper.Set(config.JiraEmailViperKey, ...) call so it only runs in the Jira-email
update branch; use the existing setConfig logic and JiraToken/JiraEmail handling
to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0d2a9445-2aa8-48d2-a03c-81b1244c5f4d
📒 Files selected for processing (1)
cmd/ocm-backplane/config/set.go
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
- Coverage 53.99% 53.97% -0.02%
==========================================
Files 82 82
Lines 6323 6329 +6
==========================================
+ Hits 3414 3416 +2
- Misses 2463 2467 +4
Partials 446 446
🚀 New features to boost your workflow:
|
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Tof1973
force-pushed
the
clacombe/config-set-jira-email
branch
from
f18c568 to
3dfda8d
Compare
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / Why we need it?
Add missing config set jira-email argument
Which Jira/Github issue(s) does this PR fix?
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)
/label tide/merge-method-squash
Summary by CodeRabbit
ocm backplane config setcommand now supports updating the Jira email setting.jira-email) is recognized as a supported setting.