{{ message }}
Remove AzureClusterHostedDNSInstall Featuregate#2902
Open
sadasu wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
|
Hello @sadasu! Some important instructions when contributing to openshift/api: |
openshift-ci
Bot
added
the
size/XXL
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (27)
📒 Files selected for processing (13)
💤 Files with no reviewable changes (13)
📝 WalkthroughWalkthroughAzureClusterHostedDNSInstall is removed from feature-gate registration, the AzurePlatformStatus cloudLoadBalancerConfig annotation, and the feature-gate table. Several payload-manifest feature-gate lists are updated to remove or replace the gate with AWSClusterHostedDNSInstall, AWSDualStackInstall, or AutomatedEtcdBackup. The related Infrastructure and ControllerConfig test manifests for this gate are deleted. 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The CloudLoadBalancerConfig field in AzurePlatformStatus is now ungated and available by default. The AzureClusterHostedDNSInstall feature gate has been removed from the API. Changes: - Removed +openshift:enable:FeatureGate=AzureClusterHostedDNSInstall annotation - Deleted feature gate test files - Removed FeatureGateAzureClusterHostedDNSInstall definition - Regenerated CRD manifests and feature gate configurations
sadasu
force-pushed
the
AzureClusterHostedDNS-removal
branch
from
77edcc7 to
43cb0fa
Compare
Contributor
JoelSpeed
reviewed
Jun 25, 2026
JoelSpeed
left a comment
JoelSpeed
left a comment
Contributor
There was a problem hiding this comment.
In which release did this gate go GA?
Contributor
There was a problem hiding this comment.
Tests should still be relevant, just need to remove the gating on them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.