Add watermark generator by dai-chen · Pull Request #959 · opensearch-project/sql · GitHub
Skip to content

Add watermark generator#959

Merged
dai-chen merged 2 commits into
opensearch-project:feature/maximus-m1from
dai-chen:maximus-m1/add-watermark-support
Nov 1, 2022
Merged

Add watermark generator#959
dai-chen merged 2 commits into
opensearch-project:feature/maximus-m1from
dai-chen:maximus-m1/add-watermark-support

Conversation

@dai-chen

@dai-chen dai-chen commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Chen Dai daichen@amazon.com

Description

Watermark is a monotonically increasing timestamp of the oldest work not yet completed. The work can be any grouping operation, such as aggregate or join, that accumulate stream events to a table and maintain the state. In other words, watermark is the way of how we reason about the completeness of accumulated window state.

There are several aspects of watermark implementation, including watermark generation, watermark emit frequency and watermark propagation. This PR is focused on the watermark generation which has no dependency on how we integrate with query plan later.

What's covered in this PR is the common generate strategy: Bounded Out-Of-Order Watermark Generator which allows a fixed delay for disordered data.

Issues Resolved

#953

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the enhancement New feature or request label Oct 24, 2022
@dai-chen dai-chen self-assigned this Oct 24, 2022
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen force-pushed the maximus-m1/add-watermark-support branch from a01ab67 to 2ac0fb5 Compare October 27, 2022 21:05
Signed-off-by: Chen Dai <daichen@amazon.com>
@codecov-commenter

codecov-commenter commented Oct 27, 2022

Copy link
Copy Markdown

@dai-chen dai-chen marked this pull request as ready for review October 28, 2022 22:12
@dai-chen dai-chen requested a review from a team as a code owner October 28, 2022 22:12
@dai-chen dai-chen added this to the Maximus M1 - Phase 1 milestone Oct 31, 2022

@penghuo penghuo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-chen dai-chen merged commit e8f3205 into opensearch-project:feature/maximus-m1 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants