Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.97%. Comparing base (3ca6450) to head (6c4e747).
⚠️ Report is 600 commits behind head on 2.x.

@@             Coverage Diff              @@
##                2.x     #873      +/-   ##
============================================
- Coverage     97.85%   94.97%   -2.89%     
  Complexity     2989     2989              
============================================
  Files           281      291      +10     
  Lines          7357     8015     +658     
  Branches        467      586     +119     
============================================
+ Hits           7199     7612     +413     
- Misses          157      349     +192     
- Partials          1       54      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

didn't know about synchronize

by default it will be triggered on three different types of activities: opened, synchronize, and reopened.

since it's default should types: just be removed?

You are right. From the official documentation. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows

Note: More than one activity type triggers this event. For information about each activity type, see "[Webhook events and payloads](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request)." By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened. To trigger workflows by different activity types, use the types keyword. For more information, see "[Workflow syntax for GitHub Actions](https://docs.github.com/en/articles/workflow-syntax-for-github-actions#onevent_nametypes)."

Will remove types entirely.