Add low-level create table and table exists API by dai-chen · Pull Request #834 · opensearch-project/sql · GitHub
Skip to content

Add low-level create table and table exists API#834

Merged
dai-chen merged 10 commits into
opensearch-project:feature/maximus-m1from
dai-chen:maximus/add-system-table
Sep 21, 2022
Merged

Add low-level create table and table exists API#834
dai-chen merged 10 commits into
opensearch-project:feature/maximus-m1from
dai-chen:maximus/add-system-table

Conversation

@dai-chen

@dai-chen dai-chen commented Sep 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Add create table and is table exists API on low level Table and OpenSearchClient interface. This is the prerequisite for adding system table and create materialized view functionality later. Because of only low-level code changes, IT will be added later. Publishing this PR earlier to avoid very large PR at last.

Issues Resolved

#833

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen
Add create index function in opensearch node client
9ad0031 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add create index function in opensearch rest client
b855b70 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add create index function in OpenSearchIndex table
fc564c2 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Separate index exist API from create index function
567257b 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Separate table exist API from create table function
bea9e71 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add UT and Todo comment for OpenSearch system index
78167a2 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix broken UT in core due to new API in Table interface
05a176e 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen self-assigned this Sep 15, 2022
@codecov-commenter

codecov-commenter commented Sep 15, 2022 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

@dai-chen
Add more UT and javadoc for OpenSearch data type mapping
f6692f1 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review September 15, 2022 19:56
@dai-chen dai-chen requested a review from a team as a code owner September 15, 2022 19:56
@dai-chen dai-chen requested a review from penghuo September 15, 2022 19:56
MaxKsyunz
MaxKsyunz reviewed Sep 16, 2022
View reviewed changes
Comment thread opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchClient.java Outdated
Comment thread opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchRestClient.java Outdated
Comment thread core/src/test/java/org/opensearch/sql/planner/PlannerTest.java Outdated
Comment thread core/src/test/java/org/opensearch/sql/config/TestConfig.java Outdated
Comment thread core/src/main/java/org/opensearch/sql/storage/Table.java Outdated
@dai-chen
Rename isExist to exists which looks more readable
129c32a 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen changed the title Add low-level create table and is table exist API Add low-level create table and table exists API Sep 16, 2022
joshuali925
joshuali925 approved these changes Sep 19, 2022
View reviewed changes
Comment thread opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClient.java
penghuo
penghuo approved these changes Sep 21, 2022
View reviewed changes

@penghuo penghuo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-chen dai-chen merged commit 213b6ae into opensearch-project:feature/maximus-m1 Sep 21, 2022
@dai-chen dai-chen added the enhancement New feature or request label Sep 21, 2022
@dai-chen dai-chen deleted the maximus/add-system-table branch September 21, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuo penghuo penghuo approved these changes
@joshuali925 joshuali925 joshuali925 approved these changes
+1 more reviewer
@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dai-chen dai-chen

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dai-chen @codecov-commenter @penghuo @joshuali925 @MaxKsyunz