Schedule request in worker thread by penghuo · Pull Request #748 · opensearch-project/sql · GitHub
Skip to content

Schedule request in worker thread#748

Merged
penghuo merged 1 commit into
opensearch-project:mainfrom
penghuo:scheduleRequestInWorkerThread
Aug 17, 2022
Merged

Schedule request in worker thread#748
penghuo merged 1 commit into
opensearch-project:mainfrom
penghuo:scheduleRequestInWorkerThread

Conversation

@penghuo

@penghuo penghuo commented Aug 12, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: penghuo penghuo@gmail.com

Description

  • Schedule request in worker thread.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner August 12, 2022 00:46
@codecov-commenter

codecov-commenter commented Aug 12, 2022

Copy link
Copy Markdown

dai-chen
dai-chen previously approved these changes Aug 12, 2022
joshuali925
joshuali925 previously approved these changes Aug 12, 2022
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo penghuo dismissed stale reviews from joshuali925 and dai-chen via e86b308 August 16, 2022 16:32
@penghuo penghuo force-pushed the scheduleRequestInWorkerThread branch from 2076106 to e86b308 Compare August 16, 2022 16:32
@joshuali925

Copy link
Copy Markdown
Member

just curious, why do we force push to squash commits like this? i felt reviewing is more difficult since I had to compare 2076106 and e86b308 to figure out what has changed, or is there a better way?

@penghuo penghuo merged commit ce15448 into opensearch-project:main Aug 17, 2022
@opensearch-trigger-bot

Copy link
Copy Markdown
Contributor

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Nov 1, 2022
6 tasks
@jduo jduo mentioned this pull request Oct 29, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants