Adding documentation about double quote implementation by MitchellGale · Pull Request #723 · opensearch-project/sql · GitHub
Skip to content

Adding documentation about double quote implementation#723

Merged
joshuali925 merged 10 commits into
opensearch-project:mainfrom
Bit-Quill:Integ-doubleQuote_Documentation
Aug 8, 2022
Merged

Adding documentation about double quote implementation#723
joshuali925 merged 10 commits into
opensearch-project:mainfrom
Bit-Quill:Integ-doubleQuote_Documentation

Conversation

@MitchellGale

Copy link
Copy Markdown
Contributor

Description

Adds documentation to datatypes.rst regarding implementation and functionality for double quotes being used as escape characters in some situations. See below table for example of implementation. See https://dev.mysql.com/doc/refman/8.0/en/string-literals.html mysql documentation.

+-----------+-----------+-------------+-------------+---------------+---------------+
| 'hello'   | "world"   | '"hello"'   | "'world'"   | '''hello'''   | """world"""   |
|-----------+-----------+-------------+-------------+---------------+---------------|
| hello     | world     | "hello"     | 'world'     | 'hello'       | "world"       |
+-----------+-----------+-------------+-------------+---------------+---------------+

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>

Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
@MitchellGale MitchellGale requested a review from a team as a code owner August 3, 2022 23:21
@MitchellGale MitchellGale changed the title Integ double quote documentation Adding documentation about double quote implementation Aug 3, 2022
@codecov-commenter

codecov-commenter commented Aug 3, 2022

Copy link
Copy Markdown

dai-chen
dai-chen previously approved these changes Aug 3, 2022

@dai-chen dai-chen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Comment thread docs/user/general/datatypes.rst Outdated
Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
@penghuo

penghuo commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

CI failed?
Could you merge the commits in case there is only one file change?

…ocumentation

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@joshuali925

Copy link
Copy Markdown
Member

@joshuali925 joshuali925 merged commit 921a28c into opensearch-project:main Aug 8, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the Integ-doubleQuote_Documentation branch September 13, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants