{{ message }}
Remove BWC tests#721
Merged
Merged
Conversation
…archived and not available anymore for testing. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Remove backward compatibility (BWC) tests
Member
acarbonetto
previously approved these changes
Aug 3, 2022
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
acarbonetto
approved these changes
Aug 4, 2022
Collaborator
|
Approving to unblock other failed PR for now. But not sure if we should do this the other way around (un-archive the ODFE repo). Because I recall we need to patch ODFE sometimes, archived repo blocks code merge. |
joshuali925
approved these changes
Aug 4, 2022
joshuali925
left a comment
joshuali925
left a comment
Member
There was a problem hiding this comment.
probably not needed to change script permission but ok
Member
we don't need to patch ODFE anymore as it reached EOL, but we should remove ODFE related BWC tests while keep BWC framework for OpenSearch |
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Member
|
+1 to @joshuali925, removing bcw tests seems like an undesirable effect If you agee @Yury-Fridlyand, care to open an issue to restore the bcw tests against supported versions of OpenSearch? |
Collaborator
Author
|
Sure. We can start testing upgrade scenario 1.x -> 2.x. |
Closed
Member
dai-chen
pushed a commit
to dai-chen/sql-1
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
dai-chen
pushed a commit
to dai-chen/sql-1
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
added a commit
that referenced
this pull request
Aug 16, 2022
* Backport Spring and jackson version bump Signed-off-by: Chen Dai <daichen@amazon.com> * Remove BWC tests (#721) Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com>
penghuo
pushed a commit
to penghuo/os-sql
that referenced
this pull request
Aug 17, 2022
…project#759) * Backport Spring and jackson version bump Signed-off-by: Chen Dai <daichen@amazon.com> * Remove BWC tests (opensearch-project#721) Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com>
penghuo
added a commit
that referenced
this pull request
Aug 17, 2022
* Backport Spring and jackson version bump Signed-off-by: Chen Dai <daichen@amazon.com> * Remove BWC tests (#721) Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove backward compatibility (BWC) tests with
OpenDistrofrom GitHub Actions (GHA), becauseOpenDistrowas archived and not available anymore for testing.https://opendistro.github.io/for-elasticsearch/blog/2022/08/Open-Distro-is-archived/
Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com
Description
Issues Resolved
Failing GHA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.