Add @MaxKsyunz and @Yury-Fridlyand to MAINTAINERS by dai-chen · Pull Request #687 · opensearch-project/sql · GitHub
Skip to content

Add @MaxKsyunz and @Yury-Fridlyand to MAINTAINERS#687

Merged
dai-chen merged 1 commit into
opensearch-project:mainfrom
dai-chen:add-bq-maintainer
Sep 8, 2022
Merged

Add @MaxKsyunz and @Yury-Fridlyand to MAINTAINERS#687
dai-chen merged 1 commit into
opensearch-project:mainfrom
dai-chen:add-bq-maintainer

Conversation

@dai-chen

@dai-chen dai-chen commented Jul 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Following https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#addition to update maintainer list with nominees. The maintainers have voted and agreed to this nomination and the nominee confirmed their interest in becoming co-maintainer.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen self-assigned this Jul 13, 2022
@dai-chen dai-chen force-pushed the add-bq-maintainer branch from 743a9cb to 1292df3 Compare July 13, 2022 18:42
@codecov-commenter

codecov-commenter commented Jul 13, 2022 •
edited
Loading

Copy link
Copy Markdown

acarbonetto
acarbonetto previously approved these changes Jul 13, 2022
View reviewed changes
@dai-chen dai-chen marked this pull request as ready for review July 14, 2022 17:44
@dai-chen dai-chen requested a review from a team as a code owner July 14, 2022 17:44
@dai-chen dai-chen requested a review from joshuali925 July 14, 2022 17:45
acarbonetto
acarbonetto reviewed Jul 14, 2022
View reviewed changes
Comment thread sql-cli/README.md
acarbonetto
acarbonetto previously approved these changes Jul 14, 2022
View reviewed changes
@dai-chen

dai-chen commented Jul 14, 2022

Copy link
Copy Markdown
Collaborator Author

!!! NOTE !!!: Blocking this PR until we finish the first and second step in https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#addition

@dai-chen
Add co-maintainers from BitQuill
0399ce8 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen requested review from anirudha and penghuo September 6, 2022 18:55
@dai-chen dai-chen merged commit 10fe75f into opensearch-project:main Sep 8, 2022
@dai-chen dai-chen deleted the add-bq-maintainer branch September 8, 2022 17:36
@dai-chen

dai-chen commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator Author

@dblock As the final step below, do you know how can I find repo admin to change the permission for the new maintainers?

The repo admin adjusts the new maintainer’s permissions accordingly, and merges the pull request.

@dblock

dblock commented Sep 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@dai-chen organizational owners are the only ones that can add external contributors, @CEHENKLE please help?

We have an internal tool whereas those with admin access to repos can act on behalf of the organizational owner to invite external collaborators. I've invited @MaxKsyunz and @Yury-Fridlyand so we should be all set now.

@dblock

dblock commented Sep 12, 2022

Copy link
Copy Markdown
Member

Screen Shot 2022-09-12 at 1 46 03 PM
Screen Shot 2022-09-12 at 1 46 07 PM

@dblock

dblock commented Sep 12, 2022

Copy link
Copy Markdown
Member

FYI @anirudha has the same level of access as me here, for next time

@dai-chen

dai-chen commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator Author

@dblock dblock changed the title Update maintainer list Add @MaxKsyunz and @Yury-Fridlyand to MAINTAINERS Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuo penghuo penghuo approved these changes
@joshuali925 joshuali925 joshuali925 approved these changes
@acarbonetto acarbonetto acarbonetto left review comments
@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner
+2 more reviewers
@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes
@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dai-chen dai-chen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dai-chen @codecov-commenter @dblock @penghuo @joshuali925 @Yury-Fridlyand @MaxKsyunz @acarbonetto