{{ message }}
Reverted UseSSL flag to false and removed invalid test case #671
Merged
joshuali925 merged 2 commits intoJul 7, 2022
Merged
Conversation
…st. Test case could not be completed due to breaking Windows UI changes for disabling checkboxes when host protocol is specified. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Reverted UseSSL flag to false and removed invalid test case
penghuo
approved these changes
Jul 7, 2022
dai-chen
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To conform to previous versions of the ODBC driver I have reverted the
UseSSLflags default value tofalse. Removed one invalid test case that tested a mismatch between theUseSSLflag and a specified protocol in the host url. This functionality was not implemented as it broke the Windows UI fix that disallows a specified protocol not matching theUseSSLflag.Issues Resolved
Leave default configuration for
UseSSLflag asfalse.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.