Update BI connectors and drivers readme files by Yury-Fridlyand · Pull Request #665 · opensearch-project/sql · GitHub
Skip to content

Update BI connectors and drivers readme files#665

Merged
joshuali925 merged 11 commits into
opensearch-project:mainfrom
Bit-Quill:integ-update-readmes
Jul 19, 2022
Merged

Update BI connectors and drivers readme files#665
joshuali925 merged 11 commits into
opensearch-project:mainfrom
Bit-Quill:integ-update-readmes

Conversation

@Yury-Fridlyand

@Yury-Fridlyand Yury-Fridlyand commented Jun 28, 2022

Copy link
Copy Markdown
Collaborator

Description

Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com

  • Update readmes
  • Add connectors' binaries
  • Add connectors' download links
  • Add and update connectors' installation and usage instructions
  • Update screenshots to remove ODFE references
  • Add drivers' download links
  • Reorganize connectors' file tree
  • Update GHA workflow

Issues Resolved

Fixes:
#605
#607
#629
#439
#340
#246
#257

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Yury-Fridlyand and others added 8 commits June 23, 2022 17:04
@Yury-Fridlyand
Reorganize BI connectors. Update README files. Add and fix download…
a80f68f 
… links. Add BI connectors binaries.

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Add connector installation instructions.
d993206 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Update connectors' docs and related files.
45886e1 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Update screenshots - remove ODFE references.
f385360 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Address PR feedback.
05de4a4 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Address PR feedback.
447e013 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Typo fix.
856b404 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Merge pull request #80 from Bit-Quill/dev-update-readmes
c1e9bd3 
Update BI connectors and drivers readme files
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner June 28, 2022 21:08
@codecov-commenter

codecov-commenter commented Jun 28, 2022 •
edited
Loading

Copy link
Copy Markdown

@Yury-Fridlyand
Merge remote-tracking branch 'upstream/main' into integ-update-readmes
77d0031 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
joshuali925
joshuali925 previously approved these changes Jul 11, 2022
View reviewed changes

@joshuali925 joshuali925 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Comment thread bi-connectors/TableauConnector/tableau_support.md

@joshuali925 joshuali925 Jul 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: would ODBC drivers use default or still opensearchodbc profile? if still opensearchodbc i think it's better to keep it documented somewhere

@Yury-Fridlyand Yury-Fridlyand Jul 12, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! ODBC driver still require opensearchodbc profile due to the bug, but Tableau uses JDBC driver which works with default profile. So there is no mistake.

@joshuali925 joshuali925 Jul 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. after removing that information here, users won't be able to know that ODBC driver still require opensearchodbc because no other place mentions it

I'm saying should the information be documented somewhere else? maybe in https://github.com/opensearch-project/sql/blob/main/sql-odbc/docs/user/configuration_options.md

@Yury-Fridlyand Yury-Fridlyand Jul 12, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 7694813.

@Yury-Fridlyand
Add AWS_SIGv4 auth details for ODBC.
7694813 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Merge remote-tracking branch 'upstream/main' into integ-update-readmes
2bcc1d4 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@joshuali925 joshuali925 merged commit 682ec13 into opensearch-project:main Jul 19, 2022
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jul 21, 2022
Merged
6 tasks
@Yury-Fridlyand Yury-Fridlyand deleted the integ-update-readmes branch August 8, 2022 16:30
This was referenced Sep 12, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuo penghuo penghuo approved these changes
@joshuali925 joshuali925 joshuali925 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yury-Fridlyand @codecov-commenter @penghuo @joshuali925