{{ message }}
Add match_phrase_prefix#661
Merged
penghuo merged 37 commits intoJul 11, 2022
Merged
Conversation
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Change generateQueries signature to use more appropriate Map type. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
…quired Add match_phrase_prefix to SQL with required parameters.
Private constants look odd. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
A convenience method to simplify writing tests. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
…l-opt match_phrase_prefix in SQL with optional parameters
…refix-#186 # Conflicts: # core/src/main/java/org/opensearch/sql/expression/DSL.java # core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java # core/src/test/java/org/opensearch/sql/analysis/ExpressionAnalyzerTest.java # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/filter/FilterQueryBuilder.java # opensearch/src/test/java/org/opensearch/sql/opensearch/storage/script/filter/FilterQueryBuilderTest.java # sql/src/main/antlr/OpenSearchSQLLexer.g4 # sql/src/main/antlr/OpenSearchSQLParser.g4
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
…l-req Add match_phrase_prefix support to where command in PPL
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
…l-itests Add integration tests for match_phrase_prefix in SQL
- match_phrase was used in a couple places. - some optional parameters were missing. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
match_phrase_prefix documentation for SQL and PPL
…l_it Integration tests for match_phrase_prefix in PPL
…refix-#186 # Conflicts: # core/src/main/java/org/opensearch/sql/expression/DSL.java # docs/user/dql/functions.rst # docs/user/ppl/functions/relevance.rst
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Add support for match_phrase_prefix in SQL and PPL
…prefix-#186 Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> # Conflicts: # core/src/main/java/org/opensearch/sql/expression/function/BuiltinFunctionName.java # docs/user/dql/functions.rst # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/filter/FilterQueryBuilder.java # ppl/src/main/antlr/OpenSearchPPLLexer.g4 # ppl/src/main/antlr/OpenSearchPPLParser.g4 # sql/src/main/antlr/OpenSearchSQLParser.g4
acarbonetto
previously approved these changes
Jun 28, 2022
acarbonetto
approved these changes
Jun 30, 2022
dai-chen
approved these changes
Jul 8, 2022
dai-chen
left a comment
dai-chen
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your changes!
Collaborator
There was a problem hiding this comment.
np: use import statement instead?
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for match_phrase_prefix in SQL and PPL.
Issues Resolved
#186
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.