Remove explicit node version for workbench by joshuali925 · Pull Request #588 · opensearch-project/sql · GitHub
Skip to content

Remove explicit node version for workbench#588

Merged
joshuali925 merged 3 commits into
opensearch-project:mainfrom
joshuali925:remove-explicit-node
Apr 22, 2022
Merged

Remove explicit node version for workbench#588
joshuali925 merged 3 commits into
opensearch-project:mainfrom
joshuali925:remove-explicit-node

Conversation

@joshuali925

@joshuali925 joshuali925 commented Apr 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Joshua Li joshuali925@gmail.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925
Remove explicit node version for workbench
201d728 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 requested a review from a team as a code owner April 22, 2022 19:39
tmarkley
tmarkley reviewed Apr 22, 2022
View reviewed changes
Comment thread .github/workflows/sql-workbench-test-and-build-workflow.yml

@tmarkley tmarkley Apr 22, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the Dashboards .nvmrc file? Similar to what we do in Dashboards: https://github.com/tmarkley/OpenSearch-Dashboards/blob/c67b31e732995207ae432f24b393c902ec326b96/.github/workflows/build_and_test_workflow.yml#L32-L36

@joshuali925 joshuali925 Apr 22, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, updated

@joshuali925
Use nvmrc
2b2d381 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925
Update nvmrc path
264d9c0 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
tmarkley
tmarkley reviewed Apr 22, 2022
View reviewed changes
Comment thread .github/workflows/sql-workbench-test-and-build-workflow.yml Outdated
uses: actions/setup-node@v2
with:
node-version: '14.18.2'
node-version-file: ".nvmrc"

@tmarkley tmarkley Apr 22, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to point to the OpenSearch Dashboards directory to get this to work.

@tmarkley tmarkley Apr 22, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it :)

@codecov-commenter

codecov-commenter commented Apr 22, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #588 (264d9c0) into main (061456c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #588   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
  Complexity     2743     2743           
=========================================
  Files           276      276           
  Lines          7455     7455           
  Branches        551      551           
=========================================
  Hits           7052     7052           
  Misses          349      349           
  Partials         54       54
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061456c...264d9c0. Read the comment docs.

@joshuali925 joshuali925 merged commit a7d4395 into opensearch-project:main Apr 22, 2022
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Apr 22, 2022
@joshuali925 @github-actions
Remove explicit node version for workbench (#588)
2935cc1 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit a7d4395)
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request Apr 22, 2022
Merged
joshuali925 added a commit that referenced this pull request Apr 25, 2022
@opensearch-trigger-bot @joshuali925
Remove explicit node version for workbench (#588) (#589)
eb65d2d 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit a7d4395)

Co-authored-by: Joshua Li <joshuali925@gmail.com>
Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 5, 2022
@Yury-Fridlyand
Backport workbench CI fixes from opensearch-project#588 and opensearc…
01a842d 
…h-project#704.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 5, 2022
@Yury-Fridlyand
Fix CI workflows.
75c3da1 
* Fix java installation for SQL plugin workflow;
* Backport workbench CI fixes from opensearch-project#588 and opensearch-project#704.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 5, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mengweieric mengweieric mengweieric approved these changes
+2 more reviewers
@tmarkley tmarkley tmarkley left review comments
@kavithacm kavithacm kavithacm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joshuali925 @codecov-commenter @tmarkley @kavithacm @mengweieric