Fix doctest not running issue by jackiehanyang · Pull Request #575 · opensearch-project/sql · GitHub
Skip to content

Fix doctest not running issue#575

Merged
penghuo merged 1 commit into
opensearch-project:mainfrom
jackiehanyang:main
Apr 21, 2022
Merged

Fix doctest not running issue#575
penghuo merged 1 commit into
opensearch-project:mainfrom
jackiehanyang:main

Conversation

@jackiehanyang

@jackiehanyang jackiehanyang commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: jackiehanyang jkhanjob@gmail.com

Description

  • Fix doctest not running issue.
  • Comment out ad in doctest running list as it takes more time to investigate. It looks like something is wrong in the doctest-cluster transport layer when ppl makes the call to ml-commons. Will take look into it.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter

codecov-commenter commented Apr 20, 2022

Copy link
Copy Markdown

@jackiehanyang jackiehanyang force-pushed the main branch 11 times, most recently from a364f8c to 70b90c6 Compare April 20, 2022 22:13
Signed-off-by: jackiehanyang <jkhanjob@gmail.com>
@jackiehanyang jackiehanyang changed the title Fix doctest for AD command Fix doctest not running issue Apr 20, 2022
@jackiehanyang jackiehanyang marked this pull request as ready for review April 20, 2022 22:53
@jackiehanyang jackiehanyang requested a review from a team as a code owner April 20, 2022 22:53

@joshuali925 joshuali925 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@penghuo penghuo merged commit e70b38a into opensearch-project:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants