Bump version to 1.3.1 by gaiksaya · Pull Request #517 · opensearch-project/sql · GitHub
Skip to content

Bump version to 1.3.1#517

Merged
gaiksaya merged 4 commits into
opensearch-project:1.3from
gaiksaya:1.3.1
Mar 29, 2022
Merged

Bump version to 1.3.1#517
gaiksaya merged 4 commits into
opensearch-project:1.3from
gaiksaya:1.3.1

Conversation

@gaiksaya

@gaiksaya gaiksaya commented Mar 26, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com

Description

Bump version to 1.3.1

Issues Resolved

opensearch-project/opensearch-build#1805

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya
Bump version to 1.3.1
56b9789 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya gaiksaya requested a review from a team as a code owner March 26, 2022 00:35
@gaiksaya

gaiksaya commented Mar 28, 2022

Copy link
Copy Markdown
Member Author

@dai-chen

dai-chen commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator 
2022-03-28T22:25:01.0633301Z | Exception in thread "main" java.lang.IllegalArgumentException: Plugin [opensearch-ml] was built for OpenSearch version 1.3.0 but version 1.3.1 is running
2022-03-28T22:25:01.0633956Z | 	at org.opensearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:392)
2022-03-28T22:25:01.0634612Z | 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:815)
2022-03-28T22:25:01.0635278Z | 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:870)
2022-03-28T22:25:01.0635914Z | 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:275)
2022-03-28T22:25:01.0636507Z | 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:249)
2022-03-28T22:25:01.0637112Z | 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:100)
2022-03-28T22:25:01.0637689Z | 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
2022-03-28T22:25:01.0638209Z | 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
2022-03-28T22:25:01.0638714Z | 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
2022-03-28T22:25:01.0639194Z | 	at org.opensearch.cli.Command.main(Command.java:101)
2022-03-28T22:25:01.0639637Z | 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)

Need to bump dependency plugin version as well?

@gaiksaya
Bump ml
6d76cc1 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya

gaiksaya commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Need to bump dependency plugin version as well?

Missed it. Bumped it now. Thanks!

@codecov-commenter

codecov-commenter commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #517 (2cd49a5) into 1.3 (be42907) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3     #517   +/-   ##
=========================================
  Coverage     95.25%   95.25%           
  Complexity     2746     2746           
=========================================
  Files           276      276           
  Lines          7416     7416           
  Branches        545      545           
=========================================
  Hits           7064     7064           
  Misses          298      298           
  Partials         54       54
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be42907...2cd49a5. Read the comment docs.

@dai-chen

dai-chen commented Mar 29, 2022

Copy link
Copy Markdown
Collaborator

It seems the same opensearch-ml-client error. Could we refer to other repo and check if any change missed? Or ask help from ML client owner?

@joshuali925

joshuali925 commented Mar 29, 2022

Copy link
Copy Markdown
Member

doctest/resources/ml-commons/opensearch-ml-1.3.0.0-SNAPSHOT.zip
this also needs to be 1.3.1?

@gaiksaya
Add new zip
f035135 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya

gaiksaya commented Mar 29, 2022

Copy link
Copy Markdown
Member Author

@gaiksaya
Updated release drafter
2cd49a5 
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
joshuali925
joshuali925 approved these changes Mar 29, 2022
View reviewed changes

@joshuali925 joshuali925 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

dai-chen
dai-chen approved these changes Mar 29, 2022
View reviewed changes

@dai-chen dai-chen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@gaiksaya gaiksaya merged commit 20bff4c into opensearch-project:1.3 Mar 29, 2022
@gaiksaya gaiksaya deleted the 1.3.1 branch March 29, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes
@dai-chen dai-chen dai-chen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaiksaya @dai-chen @codecov-commenter @joshuali925