Improve coderabbit config by ykmr1224 · Pull Request #5048 · opensearch-project/sql · GitHub
Skip to content

Improve coderabbit config#5048

Merged
ykmr1224 merged 3 commits into
opensearch-project:mainfrom
ykmr1224:coderabbit-improve
Jan 26, 2026
Merged

Improve coderabbit config#5048
ykmr1224 merged 3 commits into
opensearch-project:mainfrom
ykmr1224:coderabbit-improve

Conversation

@ykmr1224

Copy link
Copy Markdown
Collaborator

Description

  • Improve CodeRabbit config based on recent PR
  • Removed General review instructions since it was not valid config in coderabbit.yml

Related Issues

n/a

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@coderabbitai

coderabbitai Bot commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

@LantaoJin LantaoJin added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 15, 2026

@dai-chen dai-chen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious are these new tenets collected / summarized from somewhere?

Comment thread .coderabbit.yaml Outdated
Comment thread .coderabbit.yaml
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.coderabbit.yaml:
- Around line 161-172: The tone_instructions entry is currently an array and
misplaced; change it to a single top-level string under the key
tone_instructions (not nested under reviews) and condense the content to one
clear sentence <=250 characters; update the existing array value (referenced as
tone_instructions) to a single-line string that summarizes the most important
directives (conciseness, focus on functional issues, avoid repeated suggestions)
so the schema accepts it.

Comment thread .coderabbit.yaml Outdated

@RyanL1997 RyanL1997 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ykmr1224 , thanks for the change.

Comment thread .coderabbit.yaml Outdated
dai-chen
dai-chen previously approved these changes Jan 20, 2026
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 merged commit c9cddfc into opensearch-project:main Jan 26, 2026
38 checks passed
asifabashar pushed a commit to asifabashar/sql that referenced this pull request Jan 26, 2026
* Improve coderabbit config

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Address comment

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* update REVIEW_GUIDELINES.md

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 deleted the coderabbit-improve branch January 27, 2026 20:02
asifabashar pushed a commit to asifabashar/sql that referenced this pull request Jan 27, 2026
* Improve coderabbit config

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Address comment

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* update REVIEW_GUIDELINES.md

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants