[Backport 2.19-dev] Feature addtotals and addcoltotals by opensearch-trigger-bot[bot] · Pull Request #4959 · opensearch-project/sql · GitHub
Skip to content

[Backport 2.19-dev] Feature addtotals and addcoltotals#4959

Closed
opensearch-trigger-bot[bot] wants to merge 1 commit into
2.19-devfrom
backport/backport-4754-to-2.19-dev
Closed

[Backport 2.19-dev] Feature addtotals and addcoltotals#4959
opensearch-trigger-bot[bot] wants to merge 1 commit into
2.19-devfrom
backport/backport-4754-to-2.19-dev

Conversation

@opensearch-trigger-bot

@opensearch-trigger-bot opensearch-trigger-bot Bot commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Backport 15e2411 from #4754.

@github-actions @coderabbitai
Feature addtotals and addcoltotals (#4754)
f609394 
* Feature addtotals and addcoltotals #4754

Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* Update integ-test/src/test/java/org/opensearch/sql/security/CrossClusterSearchIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <abashar@apple.com>
Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <abashar@apple.com>
Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <abashar@apple.com>
Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <abashar@apple.com>
Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* Update core/src/main/java/org/opensearch/sql/ast/tree/AddColTotals.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <abashar@apple.com>
Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* syntax error fix

Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* syntax error fix

Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* trigger ci workflow

Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

* remove line wrapping for relavant md files per recommendation

Signed-off-by: Asif Bashar <asif.bashar@gmail.com>

---------

Signed-off-by: Asif Bashar <asif.bashar@gmail.com>
Signed-off-by: Asif Bashar <abashar@apple.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
(cherry picked from commit 15e2411)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

@dai-chen dai-chen mentioned this pull request Dec 15, 2025
Closed
@dai-chen

dai-chen commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator 
CrossClusterSearchIT > testCrossClusterAddTotals() FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:46487], URI [/_plugins/_ppl], status line [HTTPr]
    {
      "error": {
        "reason": "There was internal problem at backend",
        "details": "addtotals is supported only when plugins.calcite.enabled=true",
        "type": "UnsupportedOperationException"
      },
      "status": 500
    }
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:479)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:371)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:346)
        at app//org.opensearch.sql.ppl.PPLIntegTestCase.executeQueryToString(PPLIntegTestCase.java:57)
        at app//org.opensearch.sql.ppl.PPLIntegTestCase.executeQuery(PPLIntegTestCase.java:53)
        at app//org.opensearch.sql.security.CrossClusterSearchIT.testCrossClusterAddTotals(CrossClusterSearchIT.java:254)

@dai-chen dai-chen mentioned this pull request Dec 15, 2025
Open
@dai-chen

dai-chen commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator

@dai-chen dai-chen closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner
@kavithacm kavithacm Awaiting requested review from kavithacm
@derek-ho derek-ho Awaiting requested review from derek-ho
@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner
@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner
@YANG-DB YANG-DB Awaiting requested review from YANG-DB
@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner
@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner
@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner
@seankao-az seankao-az Awaiting requested review from seankao-az
@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz
@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand
@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner
@forestmvey forestmvey Awaiting requested review from forestmvey
@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner
@GumpacG GumpacG Awaiting requested review from GumpacG
@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner
@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner
@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner
@qianheng-aws qianheng-aws Awaiting requested review from qianheng-aws qianheng-aws is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen