Fix IT on 2.x - address breaking changes from upstream. by Yury-Fridlyand · Pull Request #1659 · opensearch-project/sql · GitHub
Skip to content

Fix IT on 2.x - address breaking changes from upstream.#1659

Merged
MaxKsyunz merged 1 commit into
opensearch-project:2.xfrom
Bit-Quill:fix-IT-in-2.x
May 25, 2023
Merged

Fix IT on 2.x - address breaking changes from upstream.#1659
MaxKsyunz merged 1 commit into
opensearch-project:2.xfrom
Bit-Quill:fix-IT-in-2.x

Conversation

@Yury-Fridlyand

@Yury-Fridlyand Yury-Fridlyand commented May 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

IT fails on 2.x branch (can't compile)

2023-05-25T18:49:40.0119575Z /home/runner/work/sql/sql/integ-test/src/test/java/org/opensearch/sql/legacy/OpenSearchSQLRestTestCase.java:36: error: package org.opensearch.core.internal.io does not exist
2023-05-25T18:49:40.0120005Z 
2023-05-25T18:49:40.0120688Z import org.opensearch.core.internal.io.IOUtils;

caused by opensearch-project/OpenSearch#7612
Fortunately, it is a simple fix.

on main it was fixed in scope of #1512, but this specific fix wasn't backported.

Issues Resolved

Fix CI on 2.x

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand
Fix IT.
f3670d2 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@codecov

codecov Bot commented May 25, 2023 •
edited
Loading

Copy link
Copy Markdown

@MaxKsyunz MaxKsyunz merged commit c04dfb6 into opensearch-project:2.x May 25, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the fix-IT-in-2.x branch May 25, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes
@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons
@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner
@kavithacm kavithacm Awaiting requested review from kavithacm
@derek-ho derek-ho Awaiting requested review from derek-ho
@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner
@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner
@YANG-DB YANG-DB Awaiting requested review from YANG-DB
@rupal-bq rupal-bq Awaiting requested review from rupal-bq
@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner
@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar
@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner
@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner
@seankao-az seankao-az Awaiting requested review from seankao-az
@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner
@GumpacG GumpacG Awaiting requested review from GumpacG
+2 more reviewers
@forestmvey forestmvey forestmvey approved these changes
@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yury-Fridlyand @forestmvey @MaxKsyunz @acarbonetto