{{ message }}
Add Support for Nested Function Use In WHERE Clause Predicate Expresion#1657
Merged
acarbonetto merged 2 commits intoMay 30, 2023
Conversation
forestmvey
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
Collaborator
There was a problem hiding this comment.
Why? HAVING implemented the same way as WHERE
Collaborator
Author
There was a problem hiding this comment.
Not sure I understand your question, but I implemented the fallback mechanism in AstBuilder to allow for a fallback specific to the nested function used in the HAVING clause. The old fallback mechanism could not determine between clauses for the filter, and we now support nested in the WHERE clause and not the HAVING so we need to differentiate between nested used in each.
Collaborator
There was a problem hiding this comment.
I think if you remove this check, nested would be automatically supported in HAVING, so why not? Less complexity, more functionality.
Collaborator
Author
There was a problem hiding this comment.
Good point, may just work as is, though group by is not supported for nested yet. Will need to verify and add tests though, if it fits in the timeline maybe we can support in this release.
Yury-Fridlyand
approved these changes
May 26, 2023
GumpacG
approved these changes
May 29, 2023
acarbonetto
approved these changes
May 30, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
force-pushed
the
integ-nested-where-clause-predicate-expression
branch
from
5dc02e0 to
eb48a0a
Compare
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
May 30, 2023
…on (#1657) * Adding support for nested function used in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add support for LIKE with nested query in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com> (cherry picked from commit 6d796ee)
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
May 30, 2023
…on (#1657) * Adding support for nested function used in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add support for LIKE with nested query in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com> (cherry picked from commit 6d796ee)
forestmvey
added a commit
that referenced
this pull request
May 30, 2023
…on (#1657) Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
that referenced
this pull request
May 30, 2023
…on (#1657) Signed-off-by: forestmvey <forestv@bitquilltech.com>
6 tasks
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…on (opensearch-project#1657) * Adding support for nested function used in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add support for LIKE with nested query in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…on (opensearch-project#1657) * Adding support for nested function used in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add support for LIKE with nested query in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…on (opensearch-project#1657) * Adding support for nested function used in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add support for LIKE with nested query in predicate expression. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
This was referenced Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Syntax:
nested( [field] | [field,path] )Add support for use of the nested function in the
WHEREclause as a predicate expression. Supportsnestedfunction on left of operator, and literal on right. When usingnestedfunction inWHEREclause, the inner hits of the query are not added to thenestedquery DSL. To do this you must use thenestedfunction in conjunction with aSELECTclause nested function call. See documentation for this nested implementation HERE (WIP).Example Queries
SELECT message.info FROM nested_objects WHERE nested(message.info, message) = 'a';SELECT nested(message.info) FROM nested_objects WHERE nested(message.info, message) = 'a';SELECT message.info FROM nested_objects WHERE nested(message.info) = 'a' OR nested(comment.data) = 'b' AND nested(message.dayOfWeek) = 4;Issues Resolved
Issue: 1111
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.