Update Gradle Wrapper to 7.6.1 by dbwiddis · Pull Request #1584 · opensearch-project/sql · GitHub
Skip to content

Update Gradle Wrapper to 7.6.1#1584

Closed
dbwiddis wants to merge 1 commit into
opensearch-project:mainfrom
dbwiddis:gradlewrapper
Closed

Update Gradle Wrapper to 7.6.1#1584
dbwiddis wants to merge 1 commit into
opensearch-project:mainfrom
dbwiddis:gradlewrapper

Conversation

@dbwiddis

Copy link
Copy Markdown
Member

Description

Gradle versions before 7.6 are incompatible with JDK 19 and later.

Some GitHub action backend code using jackson-core 2.5.0 is failing builds because it includes an MRJAR with JDK 19 code. See, for example, this failed action.

There are other incompatibilities in the build for Gradle 8, so 7.6.1 is the only option to keep a working build.

This commit is the result of executing ./gradlew wrapper.

Issues Resolved

N/A

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass, including unit test, integration test and doctest
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
    • [ ] New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

@MaxKsyunz

Copy link
Copy Markdown
Collaborator

Thank you @dbwiddis !

@GumpacG has a PR (#1580 ) that updates Gradle and fixes build issues due to refactor in OpenSearch. It makes sense to combine the two.

@MaxKsyunz MaxKsyunz mentioned this pull request Apr 26, 2023
6 tasks
@dbwiddis

Copy link
Copy Markdown
Member Author

@GumpacG has a PR (#1580 ) that updates Gradle and fixes build issues due to refactor in OpenSearch. It makes sense to combine the two.

Yep, I didn't see that when I started the process, so it looks like we were both doing it at the same time.

For reference/clarity, simply updating the version in the properties (as #1580 does) is sufficient to get around the bug. Actually executing gradle wrapper also updates some of the supporting script/batch files and provides a local jar that eliminates the need to download it from gradle every time, saving a few seconds off build time.

@MaxKsyunz

Copy link
Copy Markdown
Collaborator

@MaxKsyunz MaxKsyunz closed this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants