Update SQL plugin to resolve build failures by MaxKsyunz · Pull Request #1571 · opensearch-project/sql · GitHub
Skip to content

Update SQL plugin to resolve build failures#1571

Merged
penghuo merged 1 commit into
opensearch-project:mainfrom
Bit-Quill:chore/immutableopenmap-refactor
Apr 24, 2023
Merged

Update SQL plugin to resolve build failures#1571
penghuo merged 1 commit into
opensearch-project:mainfrom
Bit-Quill:chore/immutableopenmap-refactor

Conversation

@MaxKsyunz

@MaxKsyunz MaxKsyunz commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

Fix failing build due to upstream refactor.

Issues Resolved

#1570

Check List

  • All tests pass, including unit test, integration test and doctest
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@codecov-commenter

codecov-commenter commented Apr 21, 2023

Copy link
Copy Markdown

@MaxKsyunz MaxKsyunz marked this pull request as draft April 21, 2023 17:16
@MaxKsyunz MaxKsyunz marked this pull request as ready for review April 24, 2023 17:02

@Yury-Fridlyand Yury-Fridlyand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI pass except BWC. Can we ignore it for now?

@penghuo penghuo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ignore bwc failed test.

@penghuo penghuo merged commit 4522422 into opensearch-project:main Apr 24, 2023
@penghuo

penghuo commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

@MaxKsyunz MaxKsyunz deleted the chore/immutableopenmap-refactor branch April 27, 2023 05:42
acarbonetto pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 28, 2023
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Jun 27, 2023
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
(cherry picked from commit 4522422)
Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jun 27, 2023
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand added a commit that referenced this pull request Jun 27, 2023
* Update SQL plugin for core refactor (#1571)

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Fix plugin compilation (#1580)

* Changed gradle version and removed values iterator

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Update a test to match new indexResponse.aliases() type.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

* Ran ./gradlew wrapper

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

---------

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697 (#1667)

* Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

* Don't check column names on H2 results for correctness tests as described in #1667 (comment).

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR review comment.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants