{{ message }}
Documentation and other papercuts for datasource api launch#1530
Merged
vamsimanohar merged 1 commit intoApr 17, 2023
Merged
Conversation
vamsimanohar
force-pushed
the
datasources-documentation
branch
2 times, most recently
from
cfdeb0d to
520d6d7
Compare
vamsimanohar
force-pushed
the
datasources-documentation
branch
from
520d6d7 to
632e264
Compare
vamsimanohar
requested review from
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48 and
rupal-bq
as code owners
5 tasks
vamsimanohar
force-pushed
the
datasources-documentation
branch
2 times, most recently
from
1846078 to
8ce367c
Compare
penghuo
previously approved these changes
Apr 17, 2023
Collaborator
There was a problem hiding this comment.
This will extend CI run for 20 sec just for sleeping few times (few classes). Is it possible to do a conditional sleep? It is necessary to wait more than one time?
Member
Author
There was a problem hiding this comment.
I need to query prometheus in a loop till it generates metrics.
I can reduce this to 10sec.
Collaborator
There was a problem hiding this comment.
It will be great if you can, or consider this to follow-up update:
while (!isMetricsGenerated()) {
sleep(100);
}
Member
Author
There was a problem hiding this comment.
will follow up in the next release. Thanks.
vamsimanohar
force-pushed
the
datasources-documentation
branch
from
8ce367c to
c5a94ca
Compare
rupal-bq
previously approved these changes
Apr 17, 2023
YANG-DB
previously approved these changes
Apr 17, 2023
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vamsimanohar
force-pushed
the
datasources-documentation
branch
from
c5a94ca to
f77f398
Compare
anirudha
approved these changes
Apr 17, 2023
penghuo
approved these changes
Apr 17, 2023
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit fd1d7d8)
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit fd1d7d8)
vamsimanohar
added a commit
that referenced
this pull request
Apr 17, 2023
vamsimanohar
added a commit
that referenced
this pull request
Apr 17, 2023
acarbonetto
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Apr 28, 2023
…ch-project#1530) Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#1477
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.