Added COSH to V2 engine by matthewryanwells · Pull Request #1428 · opensearch-project/sql · GitHub
Skip to content

Added COSH to V2 engine#1428

Merged
dai-chen merged 2 commits into
opensearch-project:mainfrom
Bit-Quill:integ-cosh
Mar 15, 2023
Merged

Added COSH to V2 engine#1428
dai-chen merged 2 commits into
opensearch-project:mainfrom
Bit-Quill:integ-cosh

Conversation

@matthewryanwells

@matthewryanwells matthewryanwells commented Mar 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Added COSH to V2 engine, updated documentation, added unit/IT tests

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@matthewryanwells
Added COSH to V2 engine (#244)
2d0e1db 
* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@matthewryanwells matthewryanwells requested a review from a team as a code owner March 13, 2023 16:27
@codecov-commenter

codecov-commenter commented Mar 13, 2023

Copy link
Copy Markdown

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 14, 2023
Closed
10 tasks
acarbonetto
acarbonetto previously approved these changes Mar 14, 2023
View reviewed changes
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Mar 15, 2023
View reviewed changes
@dai-chen dai-chen merged commit 8dad71f into opensearch-project:main Mar 15, 2023
@opensearch-trigger-bot

opensearch-trigger-bot Bot commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

@Yury-Fridlyand Yury-Fridlyand deleted the integ-cosh branch April 20, 2023 15:38
matthewryanwells added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 20, 2023
@matthewryanwells
Added COSH to V2 engine (#244) (opensearch-project#1428)
e59b78f 
* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8dad71f)
@matthewryanwells matthewryanwells mentioned this pull request Apr 20, 2023
Merged
6 tasks
dai-chen pushed a commit that referenced this pull request Apr 20, 2023
@matthewryanwells
Added COSH to V2 engine (#244) (#1428) (#1565)
aa5b3e0 
* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8dad71f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dai-chen dai-chen dai-chen approved these changes
@acarbonetto acarbonetto acarbonetto left review comments
@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner
+1 more reviewer
@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x enhancement New feature or request new-engine-gap SQL v2.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthewryanwells @codecov-commenter @dai-chen @Yury-Fridlyand @acarbonetto