{{ message }}
Minor clean up of datetime and other classes (#198)#1310
Merged
Conversation
Yury-Fridlyand
force-pushed
the
integ-cleanupcode
branch
from
a6b4f48 to
c56806c
Compare
MaxKsyunz
previously approved these changes
Feb 7, 2023
acarbonetto
previously approved these changes
Feb 7, 2023
| */ | ||
| plugin ':opensearch-sql-plugin' | ||
| testDistribution = 'integ_test' | ||
| testDistribution = 'archive' |
Collaborator
There was a problem hiding this comment.
need this for painless
Yury-Fridlyand
dismissed stale reviews from acarbonetto and MaxKsyunz
via
1b65b8f
Yury-Fridlyand
force-pushed
the
integ-cleanupcode
branch
from
da8a837 to
1b65b8f
Compare
Collaborator
Author
|
Rebased |
Yury-Fridlyand
force-pushed
the
integ-cleanupcode
branch
from
5b7e30b to
7cda2e4
Compare
Collaborator
Author
|
Rebased again |
dai-chen
previously approved these changes
Feb 15, 2023
dai-chen
left a comment
dai-chen
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the refactoring!
penghuo
previously approved these changes
Feb 15, 2023
Yury-Fridlyand
dismissed stale reviews from penghuo and dai-chen
via
c4c16cd
Collaborator
Author
|
Rebased again, please re-review |
dai-chen
previously approved these changes
Feb 16, 2023
acarbonetto
previously approved these changes
Mar 21, 2023
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
dismissed stale reviews from acarbonetto and dai-chen
via
62120c1
Yury-Fridlyand
force-pushed
the
integ-cleanupcode
branch
from
5e89255 to
62120c1
Compare
Yury-Fridlyand
requested review from
YANG-DB,
anirudha,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
ps48,
rupal-bq and
vamsimanohar
as code owners
dai-chen
approved these changes
Apr 18, 2023
MaxKsyunz
approved these changes
Apr 20, 2023
Contributor
acarbonetto
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Apr 28, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MitchellGale-BitQuill mitchellg@bitquilltech.com
Signed-off-by: Yury-Fridlyand yury.fridlyand@improving.com
Co-authored-by: Yury-Fridlyand yury.fridlyand@improving.com
Description
Clean up lexer to make future changes easier. Make changes to documentation and code to make cleaner.
EqualsAndHashCodecompilation warningsExprTimestampValue.ZONEconstant toDateTimeUtilsExprDatetimeValueformatter toDateTimeFormattersDateTimeFunctionandMathematicalFunctionFunctionDSLimport by static imports to simplify codeNULLandMISSINGvaluesEnvironmentmock from some unit tests, because it is not needed anymorerstvalidator warningsnow-like functions truly parametrizedarchivewhich has built-in modules - this requires for some added doctestsSee team review and discussion in Bit-Quill#198
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.