Deprecated Spring IoC and using Guice instead by penghuo · Pull Request #1177 · opensearch-project/sql · GitHub
Skip to content

Deprecated Spring IoC and using Guice instead#1177

Merged
dai-chen merged 4 commits into
opensearch-project:mainfrom
penghuo:hp/main/guice
Dec 23, 2022
Merged

Deprecated Spring IoC and using Guice instead#1177
dai-chen merged 4 commits into
opensearch-project:mainfrom
penghuo:hp/main/guice

Conversation

@penghuo

@penghuo penghuo commented Dec 15, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Peng Huo penghuo@gmail.com

Description

  1. Remove the depedency on spring-beans, spring-ontext and spring-test.
  2. Using Guice from OpenSearch instead.

Issues Resolved

#741

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo self-assigned this Dec 15, 2022
@penghuo penghuo added backport 2.x infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Dec 15, 2022
@codecov-commenter

codecov-commenter commented Dec 15, 2022

Copy link
Copy Markdown

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo marked this pull request as ready for review December 15, 2022 16:51
@penghuo penghuo requested a review from a team as a code owner December 15, 2022 16:51
Comment thread plugin/src/main/java/org/opensearch/sql/plugin/SQLPlugin.java Outdated
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>

@dai-chen dai-chen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes!

@dai-chen dai-chen linked an issue Dec 23, 2022 that may be closed by this pull request
@dai-chen dai-chen merged commit 0a02009 into opensearch-project:main Dec 23, 2022
@opensearch-trigger-bot

Copy link
Copy Markdown
Contributor

penghuo added a commit to penghuo/os-sql that referenced this pull request Mar 8, 2023
* Deprecated Spring IoC and using Guice instead

Signed-off-by: Peng Huo <penghuo@gmail.com>

* fix checkstyle issue

Signed-off-by: Peng Huo <penghuo@gmail.com>

* Pass injector to action

Signed-off-by: Peng Huo <penghuo@gmail.com>

* update

Signed-off-by: Peng Huo <penghuo@gmail.com>

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 0a02009)
penghuo added a commit that referenced this pull request Mar 8, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 0a02009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Proposal for Spring framework dependency maintenance

5 participants