{{ message }}
Repository navigation
Conversation
The experimental phase for non-ASCII identifiers has now come to an end, and they can no longer be disabled. Consequently, no flag is required during compilation either.
Added ExperimentalTextMetricsFunctions feature and fixed formatting.
Updated deprecations and bugfixes in the release notes.
Removed comments about unicode identifiers and issue link.
Restore the Unicode lexer validation and NFC normalization from openscad#6968 and normalize -P parameter-set names as in openscad#7000. Keep unicode-identifiers available in non-experimental builds, enabled by default, and allow an explicit --disable=unicode-identifiers or Features preference opt-out. Preserve existing saved preferences and accept the existing --enable flag. Disable requests take precedence over enable requests. Restore integration coverage for Unicode identifiers, security-profile rejection, NFC/NFD parameter names and set selection, and opt-out behavior.
Restore the three CA certificate and TLS preference slot implementations from upstream. They remained declared in Preferences.h and referenced by Qt's generated metaobject, causing undefined references in GUI builds. Also restore loading the saved CA path and TLS preference into the UI. Validated with a full Qt6 GUI build using builtin OpenCSG/GLAD and EXPERIMENTAL=OFF, an offscreen preferences/slot smoke test, 68 unit-test assertions and ten Unicode identifier integration tests.
Contributor
Remove the stale textmetrics registration and restore regular test classification from upstream openscad#7063. The functions remain unconditionally available, and their existing tests run without --enable=textmetrics in non-experimental builds.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would mean that Unicode identifiers would always be permitted, and the experimental phase would come to an end. Since the feature was implemented, I have not been able to find any problems or issues in this regard. If I am mistaken and there are problems, I would welcome any suggestions for improvement.
Built and run against this tree on Linux (Ubuntu26) with GCC 15.2, Qt 6.10.2,
QScintilla 2.14.1, CGAL 6.1.1, Boost 1.90