ADD raise exception when failing to create sklearn flow by mfeurer · Pull Request #479 · openml/openml-python · GitHub
Skip to content

ADD raise exception when failing to create sklearn flow #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 2 commits into from
Jun 19, 2018
Merged

ADD raise exception when failing to create sklearn flow #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b4003
ADD raise exception when failing to create sklearn flow
mfeurer Jun 14, 2018
2c3479b
Update changelog
mfeurer Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/progress.rst
View file
Open in desktop
9 changes: 5 additions & 4 deletions openml/flows/flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,12 +313,13 @@ def _from_dict(cls, xml_dict):
# try to parse to a model because not everything that can be
# deserialized has to come from scikit-learn. If it can't be
# serialized, but comes from scikit-learn this is worth an exception
try:
if (
arguments['external_version'].startswith('sklearn==')
or ',sklearn==' in arguments['external_version']
):
from .sklearn_converter import flow_to_sklearn
model = flow_to_sklearn(flow)
except Exception as e:
if arguments['external_version'].startswith('sklearn'):
raise e
else:
model = None
flow.model = model

Expand Down
8 changes: 2 additions & 6 deletions openml/flows/sklearn_converter.py
View file
Open in desktop