7904037: Make OutputFormatAdapter public by galderz · Pull Request #158 · openjdk/jmh · GitHub
Skip to content

7904037: Make OutputFormatAdapter public - #158

Open
galderz wants to merge 1 commit into
openjdk:masterfrom
galderz:topic.fibula-help.010
Open

galderz wants to merge 1 commit into
openjdk:masterfrom
galderz:topic.fibula-help.010

Conversation

@galderz

@galderz galderz commented Jun 17, 2025 •

Copy link
Copy Markdown
Contributor

This is the first in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.

In this PR, we make OutputFormatAdapter public.

Why do that? This enables Fibula to reuse the same class when it wants to redirect the output from the process to the JMH output. This is useful for example when Fibula's PGO integration invokes native image to recreate the binary with the profiling information, see galderz/fibula@20eaf64

Here is the PR list for reference:

  1. Make OutputFormatAdapter public
  2. Enable BenchmarkParams construction to be overriden
  3. Enable alternative Runner instantiation and Main reuse
  4. Enable profiler classes to be reused outside of JMH
  5. Enable JMH integration tests to be executed against other impls


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/158/head:pull/158
$ git checkout pull/158

Update a local copy of the PR:
$ git checkout pull/158
$ git pull https://git.openjdk.org/jmh.git pull/158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 158

View PR using the GUI difftool:
$ git pr show -t 158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/158.diff

Using Webrev

Link to Webrev Comment

* This enables Fibula to reuse the same class
when it wants to redirect the output from the process
to the JMH output.
* This is useful for example when Fibula's PGO integration
invokes native image to recreate the binary with the profiling
information.
@galderz galderz changed the title [FibulaMake OutputFormatAdapter public [Fibula] Make OutputFormatAdapter public Jun 17, 2025
@bridgekeeper

bridgekeeper Bot commented Jun 17, 2025

Copy link
Copy Markdown

@galderz

galderz commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

Oh forgot, I'll create a CODETOOLS issue for each of these PRs, coming...

@openjdk

openjdk Bot commented Jun 17, 2025

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 17, 2025
@mlbridge

mlbridge Bot commented Jun 17, 2025

Copy link
Copy Markdown

Webrevs

@galderz galderz changed the title [Fibula] Make OutputFormatAdapter public 7903973: Make OutputFormatAdapter public Jun 17, 2025
@galderz galderz changed the title 7903973: Make OutputFormatAdapter public 7904037: Make OutputFormatAdapter public Jun 17, 2025
@bridgekeeper

bridgekeeper Bot commented Jul 15, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Jul 18, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Jul 18, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Aug 15, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Aug 18, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Sep 15, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Sep 19, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@galderz

galderz commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Oct 9, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Nov 6, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Nov 6, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Dec 4, 2025

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Dec 11, 2025

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Feb 9, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Feb 12, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Mar 12, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Mar 17, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Apr 14, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Apr 14, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk Bot removed the rfr Pull request is ready for review label Apr 14, 2026
@bridgekeeper

bridgekeeper Bot commented May 13, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented May 19, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Jun 16, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Jun 24, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Jul 22, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Jul 28, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@galderz

galderz commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Can someone review this?

@galderz

galderz commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/template append

@openjdk

openjdk Bot commented Jul 28, 2026

Copy link
Copy Markdown

@galderz The pull request template has been appended to the pull request body

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 13, 2026
@bridgekeeper

bridgekeeper Bot commented Aug 25, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Sep 8, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper

bridgekeeper Bot commented Oct 7, 2026

Copy link
Copy Markdown

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@galderz

galderz commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/touch

@openjdk

openjdk Bot commented Oct 7, 2026

Copy link
Copy Markdown

@galderz The pull request is being re-evaluated and the inactivity timeout has been reset.

@galderz

galderz commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant