{{ message }}
Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #981.
OIDExternalUserAgentIOSCustomBrowsercalledUIApplication.sharedApplicationdirectly, so-presentExternalUserAgentRequest:session:was untestable. (The iOS unit test target has no host app, so the completion handler will never fire)Functional-programming-enjoyer added DI so that the behaviour in #981 is testable:
OIDExternalUserAgentIOSCustomBrowserURLOpener, a two-method protocol to which UIApplication can conform.URLOpenerproperty and a new designated initializerinitWithURLTransformation:canOpenURLScheme:appStoreURL:URLOpener:.UnitTests/OIDExternalUserAgentIOSCustomBrowserTests.m(iOS only):YESand opens the transformed URL without consultingcanOpenURL:for the request URL (this is what Custom browser user-agent fails the flow with "Unable to open Safari." while the browser opens (it returns the result of canOpenURL:) #980 fixed).OIDErrorCodeSafariOpenError.niltransformed URL returnsNOwithout making any calls to UIApplication.OIDAuthorizationSessionreports a failure only once, even iffailExternalUserAgentFlowWithError:is called twice. Fix custom browser user-agent failing the flow when canOpenURL: returns NO #981 relies on this, since the failure now arrives from an asynchronous completion handler after the session may already have been cancelled or finished.