Add end session support by agologan · Pull Request #525 · openid/AppAuth-Android · GitHub
Skip to content

Add end session support#525

Merged
agologan merged 1 commit into
openid:masterfrom
agologan:end-session
Jan 13, 2021
Merged

Add end session support#525
agologan merged 1 commit into
openid:masterfrom
agologan:end-session

Conversation

@agologan

Copy link
Copy Markdown
Collaborator

Original-author: Sergiy Mokiyenko smokiyenko@lohika.com
See: #433

Needed the changes so I cleaned the original PR and applied existing patterns in order to match current code design.

@ghost

ghost commented Apr 8, 2020

Copy link
Copy Markdown

@agologan

Copy link
Copy Markdown
Collaborator Author

@cratrifork Per https://openid.net/specs/openid-connect-session-1_0.html#RPLogout the paramater should be the previously issued ID token.
Different vendors may support other hints as this parameter but the purpose here is not create a KeyCloak-specific implementation.

@srajkovic

Copy link
Copy Markdown

Any chance this might get reviewed and merged? We'd love to have this functionality since we're having issues with getting our logout flow to respect the App Link we have registered and go back to our app, and it's probably due to the hacky workarounds. Tagging @iainmcgin since it seems like you're a current maintainer. Happy to help if I can in some way.

@wassimsalib

Copy link
Copy Markdown

Any updates on this PR? we are currently in the same situation and this PR will solve out problems too.

@codecov-commenter

codecov-commenter commented Oct 5, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@27b62d5). Click here to learn what that means.
The diff coverage is 84.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #525   +/-   ##
=========================================
  Coverage          ?   83.84%           
  Complexity        ?      511           
=========================================
  Files             ?       47           
  Lines             ?     2470           
  Branches          ?      238           
=========================================
  Hits              ?     2071           
  Misses            ?      312           
  Partials          ?       87           
Impacted Files Coverage Δ Complexity Δ
...y/java/net/openid/appauth/RegistrationRequest.java 93.15% <ø> (ø) 9.00 <0.00> (?)
library/java/net/openid/appauth/TokenRequest.java 87.82% <ø> (ø) 8.00 <0.00> (?)
...java/net/openid/appauth/AuthorizationResponse.java 87.39% <50.00%> (ø) 13.00 <1.00> (?)
...et/openid/appauth/AuthorizationManagementUtil.java 54.54% <54.54%> (ø) 4.00 <4.00> (?)
.../java/net/openid/appauth/AuthorizationService.java 72.00% <60.00%> (ø) 19.00 <4.00> (?)
...penid/appauth/AuthorizationManagementActivity.java 82.75% <72.72%> (ø) 21.00 <2.00> (?)
...ry/java/net/openid/appauth/EndSessionResponse.java 94.44% <94.44%> (ø) 9.00 <9.00> (?)
...openid/appauth/AuthorizationManagementRequest.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...penid/appauth/AuthorizationManagementResponse.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
.../java/net/openid/appauth/AuthorizationRequest.java 92.85% <100.00%> (ø) 13.00 <2.00> (?)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b62d5...ed7e194. Read the comment docs.

Original-author: Sergiy Mokiyenko <smokiyenko@lohika.com>
@agologan

agologan commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator Author

Updated this PR integrating the latest changes.

If you need, you may grab a binary from: https://jitpack.io/#agologan/AppAuth-Android/ed7e1946ae

@chrisbanes

Copy link
Copy Markdown

FYI: this added an API breaking change (removing the 3 arg constructor from AuthorizationServiceConfiguration).

@agologan

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants