workaround androidx jetifier by auval · Pull Request #438 · openid/AppAuth-Android · GitHub
Skip to content

workaround androidx jetifier#438

Closed
auval wants to merge 3 commits into
openid:masterfrom
cwt-dev:master
Closed

workaround androidx jetifier#438
auval wants to merge 3 commits into
openid:masterfrom
cwt-dev:master

Conversation

@auval

@auval auval commented Jan 7, 2019

Copy link
Copy Markdown

This workaround prevents androidx jetifier from replacing a hard-coded android.support string with its androidx counterpart that doesn't work.
It is backward compatible with pre-androidx projects, and makes AppAuth-Android work seamlessly with androidx projects.

@codecov-io

codecov-io commented Jan 7, 2019

Copy link
Copy Markdown

@silentsudo

Copy link
Copy Markdown

This works like butter. Checked with following browser implementation

browserMatcher = new BrowserWhitelist(VersionedBrowserMatcher.CHROME_BROWSER, VersionedBrowserMatcher.CHROME_CUSTOM_TAB, VersionedBrowserMatcher.SAMSUNG_BROWSER, VersionedBrowserMatcher.SAMSUNG_CUSTOM_TAB, VersionedBrowserMatcher.FIREFOX_BROWSER, VersionedBrowserMatcher.FIREFOX_CUSTOM_TAB);

@jcloquell

Copy link
Copy Markdown

Thanks for this one! It would be really nice if it could get merged and released soon...

@nicklasl

Copy link
Copy Markdown

Also waiting for this to get merged!

@nguyenhuutinh

Copy link
Copy Markdown

waiting for this to get merged!

@hnljp

hnljp commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

#417 (comment)
An updated version of the jetifier processor is on its way:
https://issuetracker.google.com/issues/119183822#comment7
Should fix the problem.

@raincoatforever

Copy link
Copy Markdown

The new jetifier beta does not seem to solve this issue. Could we please get this merged ?

@jcloquell

Copy link
Copy Markdown

The new jetifier beta does not seem to solve this issue. Could we please get this merged ?

Indeed, I tried it a couple of days ago and it didn't fix it :/

@WilliamDenniss

Copy link
Copy Markdown
Member

@auval do you have a CLA on file? If so, can you link to it?

Comment thread library/java/net/openid/appauth/browser/BrowserSelector.java
@auval

auval commented Feb 24, 2019

Copy link
Copy Markdown
Author

@auval do you have a CLA on file? If so, can you link to it?
Working on it

@ouachman

Copy link
Copy Markdown

Hello everyone. What is the status on this issue?
I tried using the latest gradle plugin version and latest jetifier but I still can't make custom tabs working (all BrowserDescriptor return false to useCustomTab).
Is there a new release coming out soon? Otherwise is there a branch/build available with the fix that can be used via Gradle instead of the released version?
Thanks

@itsvssudheesh

Copy link
Copy Markdown

Waiting....⌛
Can someone please merge this PR

@fabiosanto

Copy link
Copy Markdown

waiting for this too...

@alosdev

alosdev commented Apr 12, 2019

Copy link
Copy Markdown

#444, therefore, no merge

alosdev added a commit to weshare-umigmbh/AppAuth-Android that referenced this pull request May 31, 2019
@auval

auval commented May 3, 2020

Copy link
Copy Markdown
Author

@auval auval closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.