do not deparse length 1 named vector by philaris · Pull Request #413 · opencpu/opencpu · GitHub
Skip to content

do not deparse length 1 named vector#413

Merged
jeroen merged 1 commit into
opencpu:masterfrom
philaris:fix_protobuf_named_char_vec_len_1
Nov 17, 2022
Merged

do not deparse length 1 named vector#413
jeroen merged 1 commit into
opencpu:masterfrom
philaris:fix_protobuf_named_char_vec_len_1

Conversation

@philaris

Copy link
Copy Markdown
Contributor

This fixes issue #412.

@jeroen jeroen merged commit 9d85c01 into opencpu:master Nov 17, 2022
@jeroen

jeroen commented Nov 17, 2022

Copy link
Copy Markdown
Member

@jeroen

jeroen commented Nov 17, 2022

Copy link
Copy Markdown
Member

Do you need this feature soon or is it mostly just for correctness?

@philaris

Copy link
Copy Markdown
Contributor Author

Do you need this feature soon or is it mostly just for correctness?

I would say it is mostly for correctness.

There is another border case in #414 which is fixed by #415.

Is there a reason you treat specially primitives as expressions at the end of function parse_post?

Another comment: As I read the code, I realized that you support application/rds in parse_post. However at https://www.opencpu.org/api.html in the "Argument formats for R function calls (HTTP POST only)" section, you do not mention rds as a possible format of POST data. What is the situation?

@jeroen

jeroen commented Nov 18, 2022

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants