{{ message }}
Repository navigation
Conversation
Since libfuse 3.15.0 (commit dba6b3983a, "Do not pass unsupported mount options to the kernel"), "atime" is no longer a known mount option, so sshfs fails with: fuse: unknown option(s): `-o atime' and the tests silently fall back to using tmpfs instead of fuse-sshfs. The option is a no-op anyway (MS_NOATIME is not set by default), and the atime flags are reset by "mount --bind -o remount" right after, so just drop it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Bind mount options which are neither mount flags nor clearing flags, i.e. "rbind" and propagation options such as "rprivate", must not change the mount flags of the source, as it is with a plain "bind". Extend the "--bind with no options" test to check these, too. Since the checks were already duplicated for the user namespace case, use a loop for that as well. This catches a bug in crun (see containers/crun#2338), which used to remount such bind mounts, clearing the ro, nosuid, nodev and noexec flags of the source. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
commented
Oct 19, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Contributor
Author
There was a problem hiding this comment.
second commit is best reviwed with --ignore-all-space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test-only changes to
mounts_sshfs.bats:Do not pass
atimeto sshfs. Since libfuse 3.15.0 (libfuse/libfuse@dba6b3983a),atimeis not a known mount option, so sshfs fails withfuse: unknown option(s): `-o atime'and the tests silently fall back to tmpfs. The option is a no-op anyway, and the atime flags are reset bymount --bind -o remountright after.Test
rbindand propagation options in the "--bind with no options" test. Options such asrbind,bind,rprivate,rbind,rslaveare not mount flags, so, same as with plainbind, the flags of the source must be kept. The test now loops over these (with and without a user namespace) instead of duplicating the checks.The second change catches a crun bug (containers/crun#2338), where plain
bindworks butrbindor a propagation option resulted in a remount clearingro,nosuid,nodevandnoexecof the source. Checked locally (tmpfs fallback): passes with runc and with crun with the fix, fails with crun without it.