Timeout wedged Codex exec calls by camwest · Pull Request #115 · openclaw/clawpatch · GitHub
Skip to content

Timeout wedged Codex exec calls - #115

Merged
steipete merged 3 commits into
openclaw:mainfrom
camwest:codex/codex-provider-timeout
May 28, 2026
Merged

Timeout wedged Codex exec calls#115
steipete merged 3 commits into
openclaw:mainfrom
camwest:codex/codex-provider-timeout

Conversation

@camwest

@camwest camwest commented May 26, 2026

Copy link
Copy Markdown
Contributor

[problem]

  • Codex exec can wedge indefinitely.
  • One stuck child blocks the run.
  • No report is emitted.

[solution]

Wire Codex through existing provider timeout handling. Default mirrors Cursor: 300s; override with CLAWPATCH_CODEX_TIMEOUT_MS or CLAWPATCH_PROVIDER_TIMEOUT_MS.

[proof]

  • Shimmed wedged Codex exec timed out at 50ms.
  • Regression asserts feature error state and released locks.
  • Checks: typecheck, lint, format, build, focused Vitest.

@camwest
camwest requested a review from a team as a code owner May 26, 2026 15:11
@clawsweeper

clawsweeper Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P1 Urgent regression or broken agent/channel workflow affecting real users now. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. labels May 26, 2026
@clawsweeper

clawsweeper Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper PR egg

🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat.

Where did the egg go?
  • The egg game starts only after the PR passes the real-behavior proof check.
  • Before that, no creature or rarity is rolled. The treat waits for real proof.
  • This is still just collectible flavor: proof affects review readiness, not creature quality.

@camwest

camwest commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Added docs in d4ff0db to make the timeout contract explicit: Codex now mirrors Cursor's 300s provider timeout default, with CLAWPATCH_CODEX_TIMEOUT_MS and CLAWPATCH_PROVIDER_TIMEOUT_MS overrides.

Behavior proof from a shimmed wedged codex exec:

clawpatch review feature-error index=1 total=1 feature=feat_cli-command_4fd29cd328 elapsed=1s error=codex provider failed: command timed out after 50ms
clawpatch review failed run=20260528T133615-e7b02e errors=1

Test Files  1 passed (1)
Tests  1 passed | 110 skipped (111)

The regression also asserts the feature is marked error and .clawpatch/locks is empty after timeout.

Checks run:

pnpm format:check
pnpm typecheck
pnpm lint
pnpm build
pnpm vitest run src/provider.test.ts src/workflow.test.ts
pnpm vitest run src/workflow.test.ts -t "times out wedged codex exec review children"

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels May 28, 2026
@steipete
steipete merged commit 9eb026a into openclaw:main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. P1 Urgent regression or broken agent/channel workflow affecting real users now. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants