{{ message }}
OBLS-812 Show Receive button only for shipped and partially received …#6004
Open
olewandowski1 wants to merge 1 commit into
Open
OBLS-812 Show Receive button only for shipped and partially received …#6004olewandowski1 wants to merge 1 commit into
olewandowski1 wants to merge 1 commit into
Conversation
github-actions
Bot
added
domain: frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…stock movements
✨ Description of Change
Link to GitHub issue or Jira ticket: https://openboxes.atlassian.net/browse/OBLS-812
Description:
Before - the Receive button was rendered unconditionally, so it appeared for every return status including Checking (not yet shipped) and Received.
After - the button is wrapped in <g:if test="${hasBeenPlaced}">, reusing the variable already defined: SHIPPED - Visible, PARTIALLY_RECEIVED - Visible, PENDING/RECEIVED - Hidden.
📷 Screenshots & Recordings (optional)