iframe-proxy

adambalcerzak · 2026-05-18T14:33:25Z

✨ Description of Change

Link to GitHub issue or Jira ticket:

Description:

📷 Screenshots & Recordings (optional)

codecov · 2026-05-18T14:45:41Z

Copilot

Pull request overview

Adds “reason for shortage” support to Stock Transfer UI/API by introducing new reason codes and exposing them via the existing reason-codes endpoint, then wiring selection/display into stock transfer pages and persisting the selected code onto OrderItem.discrepancyReasonCode.

Changes:

Added new ReasonCode values and a dedicated list for “shortage qty under receipt” reason codes.
Added a “Reason for Shortage” column to Stock Transfer (edit + check) pages and plumbed the selected reason code through the Stock Transfer API model.
Introduced new role/activity-code entries related to stock transfer notifications (not yet implemented).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/main/groovy/org/pih/warehouse/core/RoleType.groovy	Adds a new stock-transfer notification role type.
src/main/groovy/org/pih/warehouse/core/ReasonCode.groovy	Adds new reason codes + a new list method for under-receipt shortage.
src/main/groovy/org/pih/warehouse/core/ActivityCode.groovy	Adds new activity codes for stock-transfer notifications + under-receipt shortage reason selection.
src/main/groovy/org/pih/warehouse/api/StockTransferItem.groovy	Adds `reasonCode` field and serializes it to/from OrderItem.
src/js/consts/activityCode.js	Adds JS constant for `SHORTAGE_QTY_UNDER_RECEIPT`.
src/js/components/stock-transfer/utils.jsx	Propagates `reasonCode` through extracted items/split items.
src/js/components/stock-transfer/StockTransferSecondPage.jsx	Fetches reason codes and adds editable “Reason for Shortage” column.
src/js/components/stock-transfer/StockTransferCheckPage.jsx	Fetches reason codes and displays “Reason for Shortage” column.
grails-app/services/org/pih/warehouse/stockTransfer/StockTransferService.groovy	Persists shortage reason onto `OrderItem.discrepancyReasonCode`; contains TODO comments for future notifications.
grails-app/i18n/messages.properties	Adds labels for new reason codes + new stock transfer UI label.
grails-app/controllers/org/pih/warehouse/api/StockTransferApiController.groovy	Binds `reasonCode` from request payload into StockTransferItem.
grails-app/controllers/org/pih/warehouse/api/ReasonCodeApiController.groovy	Adds activity-code branch for returning the under-receipt shortage reason codes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 enum.ReasonCode.OVERAGE=More stock than expected
 enum.ReasonCode.WRONG_ITEM=Item does not match the expected product
+enum.ReasonCode.DELIVERED_SHORT=Delivered short
+enum.ReasonCode.PUTAWAY_DISCREPANCY=putaway discrepancy


+        // if (location is under receipt)
+        //      sendStockTransferNotification() -> fetch users with Stocktransfer notification role -> send
+


    // Notifications
    ENABLE_NOTIFICATIONS('ENABLE_NOTIFICATIONS'),
    ENABLE_WEBHOOKS('ENABLE_WEBHOOKS'),
    // Approval notifications (if requestor should get the notification about approval or rejection)
    ENABLE_REQUESTOR_APPROVAL_NOTIFICATIONS('ENABLE_REQUESTOR_APPROVAL_NOTIFICATIONS'),
    // Approval notifications (if fulfiller should get the notification about submited requests)
    ENABLE_FULFILLER_APPROVAL_NOTIFICATIONS('ENABLE_FULFILLER_APPROVAL_NOTIFICATIONS'),
+    ENABLE_STOCK_TRANSFER_NOTIFICATIONS('ENABLE_STOCK_TRANSFER_NOTIFICATIONS'),



    ROLE_SHIPMENT_OUTBOUND_SHIPPED_NOTIFICATION('Shipment Outbound Shipped Notifications', 100),
    ROLE_SHIPMENT_INBOUND_RECEIVED_NOTIFICATION('Shipment Inbound Received Notifications', 100),
    ROLE_SHIPMENT_OUTBOUND_RECEIVED_NOTIFICATION('Shipment Outbound Received Notifications', 100),
+    ROLE_STOCK_TRANSFER_NOTIFICATIONS('Stock Transfer Notifications', 100),


awalkowiak

Few change requests and please fix the conflicts

awalkowiak · 2026-06-24T10:29:54Z

+            if (recipientList) {
+                def g = grailsApplication.mainContext.getBean('org.grails.plugins.web.taglib.ApplicationTagLib')
+                // try to find StockTransferItem with destinationBinLocation that supports ENABLE_STOCK_TRANSFER_NOTIFICATIONS activity
+                StockTransferItem stockTransferItemWithSupportedLocation = stockTransfer?.stockTransferItems?.find {


I think we can just send it in case any of the items have a destinationBinLocation or originBinLocation with ENABLE_STOCK_TRANSFER_NOTIFICATIONS enabled

awalkowiak · 2026-06-24T11:36:29Z

+                }
+                String subject
+                if (stockTransferItemWithSupportedLocation) {
+                    subject = g.message(code: 'email.stockTransfer.message.toLocation', args: [stockTransferItemWithSupportedLocation?.destinationBinLocation?.name])


Subject can be a generic Stock transfer in ${item?.destinationBinLocation?.name ?: item?.originBinLocation?.name} no need to split into two cases.

awalkowiak · 2026-06-24T11:56:49Z

        createStockTransferTransaction(stockTransfer, order)

+
+        if (stockTransfer?.stockTransferItems?.any {


As it is done with the recently developed PRs, we should emit the event here, and the event service would sendStockTransferNotification()

Side note: I started debating with myself if this should not be published inside the createStockTransferTransaction (line 360) after each transaction is created, and later on, the message would be based on the Transaction data or even published to the webhook. But for now, we can skip it.

awalkowiak · 2026-06-24T11:59:00Z

+        <h2>${warehouse.message(code:'default.summary.label', default:'Summary') }</h2>
+        <div style="margin: 10px;">
+
+            <g:if test="${stockTransferItem?.destinationBinLocation?.supports('ENABLE_STOCK_TRANSFER_NOTIFICATIONS')}">


Let's change the message structure a bit.

Let's add a title above the table with transfer items -> There was a transfer in the <list of unique bin names from stock transfer items that support ENABLE_STOCK_TRANSFER_NOTIFICATIONS, in case there is another such location in other items> location. See details below.

"Header" with data:
a. Transfer Number: <stockTransafer.stockTransferNumber> with "View details" link next to it (like this one https://github.com/openboxes/openboxes/pull/5923/changes#diff-c29c819a35d3d11ec6625785eaf7e71aa6bd751618fc4e0f86b80471ee07be5aR19-R21)
b. Origin Facility: <origin.name>
c. Destination Facility: <destination.name>
d. Transfered by: <orderedBy.name>

Let's display all items in the table (product, origin bin, destination bin, quantity, reason code), and if the origin or the destination is a location that supports ENABLE_STOCK_TRANSFER_NOTIFICATIONS lets bold the name of it

awalkowiak · 2026-06-24T12:16:39Z

        ]
    }
+
+    static listShortageQtyUnderReceiptReasonCodes() {


Move these to the listPickingShortageReasonCodes, and use the listPickingShortageReasonCodes instead of this one

awalkowiak · 2026-06-24T12:20:00Z

            reasonCodes.addAll(getReasonCodes(ReasonCode.listPutawayDiscrepancyCodes()))
        } else if (ActivityCode.PICKING_SHORTAGE in activityCodes) {
            reasonCodes.addAll(getReasonCodes(ReasonCode.listPickingShortageReasonCodes()))
+        } else if (ActivityCode.ENABLE_STOCK_TRANSFER_NOTIFICATIONS in activityCodes) {


No need for this one, you can use reason codes for the PICKING_SHORTAGE for now on the front end.

TODO for the future

fix filtering and displaying new reason value

send notification email

add new role

add suggestions from pr Copilot

change sending email as suggested in pr

jmiranda requested a review from Copilot May 19, 2026 14:06

Copilot started reviewing on behalf of jmiranda May 19, 2026 14:06 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

github-actions Bot added the flag: schema change Hilights a pull request that contains a change to the database schema label May 27, 2026

adambalcerzak marked this pull request as ready for review May 27, 2026 09:42

jmiranda requested review from awalkowiak, druchniewicz and jmiranda June 17, 2026 15:10

awalkowiak requested changes Jun 24, 2026

View reviewed changes

adambalcerzak added 8 commits July 1, 2026 09:39

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

0e82268

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

92e8547

TODO for the future

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

1d4e672

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

c444000

fix filtering and displaying new reason value

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

2c4b1fe

send notification email

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

9592677

add new role

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

48f0960

add suggestions from pr Copilot

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI

04d732b

change sending email as suggested in pr

adambalcerzak force-pushed the feature/OBLS-513 branch from 494d36d to 04d732b Compare July 1, 2026 07:54

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI#5923

OBLS-513 Transfer Shortage Qty to Under Receipt Location on UI#5923
adambalcerzak wants to merge 8 commits into
feature/obaf-integrationfrom
feature/OBLS-513

adambalcerzak commented May 18, 2026

Uh oh!

codecov Bot commented May 18, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

awalkowiak left a comment

Uh oh!

awalkowiak Jun 24, 2026

Uh oh!

awalkowiak Jun 24, 2026

Uh oh!

awalkowiak Jun 24, 2026

Uh oh!

awalkowiak Jun 24, 2026

Uh oh!

awalkowiak Jun 24, 2026

Uh oh!

awalkowiak Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// if (location is under receipt)
		// sendStockTransferNotification() -> fetch users with Stocktransfer notification role -> send

		createStockTransferTransaction(stockTransfer, order)


		if (stockTransfer?.stockTransferItems?.any {

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

adambalcerzak commented May 18, 2026

✨ Description of Change

📷 Screenshots & Recordings (optional)

Uh oh!

codecov Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

awalkowiak left a comment

Choose a reason for hiding this comment

Uh oh!

awalkowiak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

awalkowiak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

awalkowiak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

awalkowiak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

awalkowiak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

awalkowiak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented May 18, 2026 •

edited

Loading