Support HTTPS for Consul KV by jhriggs · Pull Request #1047 · openark/orchestrator · GitHub
Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Support HTTPS for Consul KV - #1047

Merged
shlomi-noach merged 3 commits into
openark:masterfrom
jhriggs:consul-https
Feb 10, 2020
Merged

shlomi-noach merged 3 commits into
openark:masterfrom
jhriggs:consul-https

Conversation

@jhriggs

@jhriggs jhriggs commented Jan 16, 2020

Copy link
Copy Markdown
Contributor

Related issue: #874

Description

Add ConsulScheme config variable and skip TLS verification (for now).
Fixes #874.

Add ConsulScheme config variable and skip TLS verification (for now).
Fixes openark#874.
@jhriggs

jhriggs commented Jan 16, 2020

Copy link
Copy Markdown
Contributor Author

@shlomi-noach shlomi-noach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Gonna send to testing

@shlomi-noach
shlomi-noach had a problem deploying to production/mysql_cluster=conertmaster January 27, 2020 11:10 Failure
@shlomi-noach
shlomi-noach temporarily deployed to production/mysql_cluster=concertmaster January 27, 2020 11:12 Inactive
@shlomi-noach
shlomi-noach merged commit 7d21cf8 into openark:master Feb 10, 2020
@jhriggs
jhriggs deleted the consul-https branch February 10, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use ConsulAddress with https

3 participants