{{ message }}
Use default value for ref property#1202
Open
github-abcde wants to merge 4 commits intoopenapi-generators:mainfrom
Open
Use default value for ref property#1202github-abcde wants to merge 4 commits intoopenapi-generators:mainfrom
github-abcde wants to merge 4 commits intoopenapi-generators:mainfrom
Conversation
github-abcde
force-pushed
the
use_default_value_for_ref_property
branch
from
6fa4204 to
5d34403
Compare
dbanty
reviewed
Mar 15, 2025
Collaborator
dbanty
left a comment
dbanty
left a comment
There was a problem hiding this comment.
According to the OpenAPI spec, we're supposed to ignore any additional properties defined on a reference—which would include default unless I'm missing something.
The "right" way to do this might be with allOf?
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the OpenAPI spec contains an optional enum property with a default value, the default value is ignored and is always set to
UNSETin the generated client (current behavior).This PR attempts to address this, checking if a default is defined for a referenced property and applying that. If no default is defined on the property itself, the current behavior is applied (fetching the default from the parent if present and falling back to
None(UNSET) if absent).I hope I've provided everything required in this PR, but if not, please let me know :-)