{{ message }}
Merged
Conversation
a1191a6 to
fc9e78c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Release readiness review (v0.14.4 -> TARGET fc9e78c)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.14.4...fc9e78c
Release call:
🟢 GREEN LIGHT TO SHIP Patch release with narrowly scoped runtime fixes, additive sandbox configuration, matching regression tests, and no concrete blocking evidence in
v0.14.4...fc9e78c2.Scope summary:
src/agents/run_internal/streamed/runtime resume fixes,src/agents/extensions/sandbox/modal/additiveidle_timeoutsupport, focused test additions, sandbox docs/examples, and version bump to0.14.5.Risk assessment (ordered by impact):
No material risks identified.
16e04092addsget_unsent_tool_call_ids_for_interrupted_state()and threadsunsent_tool_call_idsthroughOpenAIServerConversationTracker.hydrate_from_state()so interrupted local tool outputs are not incorrectly marked as already sent;tests/test_server_conversation_tracker.pyaddstest_hydrate_from_state_preserves_unsent_outputs_from_interrupted_turn.src/agents/run_internal/agent_runner_helpers.py,src/agents/run_internal/oai_conversation.py,src/agents/run.py,src/agents/run_internal/run_loop.py,tests/test_server_conversation_tracker.pyuv run pytest tests/test_server_conversation_tracker.py -q -k interrupted_turn; pass criteria: the new resume-path test passes and prepared input still includes the expected function-call outputs on resume.response.output_item.doneevents but leavesresponse.completed.outputempty, and the fix is covered with targeted ordering/preservation tests.81c57c5estoresResponseOutputItemDoneEventitems instreamed_response_outputand backfillsterminal_response.outputbefore step resolution when the completed response is empty; new filetests/test_streamed_terminal_output_backfill.pycovers empty terminal output, preserving a non-empty terminal output, and multi-tool ordering.src/agents/run_internal/run_loop.py,tests/test_streamed_terminal_output_backfill.pyuv run pytest tests/test_streamed_terminal_output_backfill.py -q; pass criteria: all new streaming regression tests pass and streamed tool calls still resolve into final output.idle_timeoutis a user-facing additive optionNone.5be06a16addsidle_timeouttoModalSandboxClientOptionsandModalSandboxSessionState, forwards it into sandbox creation and snapshot restore, updates compatibility guards for stable field ordering, and adds focused tests for create/restore behavior.src/agents/extensions/sandbox/modal/sandbox.py,tests/extensions/test_sandbox_modal.py,tests/sandbox/test_client_options.py,tests/sandbox/test_compatibility_guards.pyuv run pytest tests/extensions/test_sandbox_modal.py -q -k idle_timeout && uv run pytest tests/sandbox/test_client_options.py tests/sandbox/test_compatibility_guards.py -q -k idle_timeout; pass criteria:idle_timeoutis forwarded during create/restore and legacy serialized state without the field still restores cleanly.Notes:
v0.14.4.HEAD:fc9e78c2f318d1ecdb9625c6296e73c9fee55d78.git status --shortreturned no changes).